Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105 #442

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Feb 14, 2024

Hi all,

This pull request contains a backport of commit openjdk/jdk@a53e8dd from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on Dec 6, 2016 and was reviewed by Phil Race.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8025439 needs maintainer approval

Issue

  • JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/442/head:pull/442
$ git checkout pull/442

Update a local copy of the PR:
$ git checkout pull/442
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 442

View PR using the GUI difftool:
$ git pr show -t 442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/442.diff

Webrev

Link to Webrev Comment

…oesn't work properly since jdk8b105

Reviewed-by: prr
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a53e8ddcad8c34fc9906e083c5933d0d1c3e9f4e 8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105 Feb 14, 2024
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review February 14, 2024 21:25
@mrserb mrserb marked this pull request as draft February 14, 2024 21:25
@mrserb mrserb marked this pull request as ready for review February 14, 2024 21:28
@openjdk
Copy link

openjdk bot commented Feb 14, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 14, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 16, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport confirmed clean.

@gnu-andrew
Copy link
Member

Tests are the same cacert failures that seem to have been caused by the host being accessed and have now gone again on later PRs.
/approve yes

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@gnu-andrew
8025439: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  • b7bda28: 8325150: (tz) Update Timezone Data to 2024a
  • ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  • 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  • e926edc: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 9aabf22: 8270517: Add Zero support for LoongArch
  • dce5300: 8168518: rcache interop with krb5-1.15

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 23, 2024
@mrserb
Copy link
Member Author

mrserb commented Feb 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit a798523.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 824dbfb: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  • 5e70a86: 8324530: Build error with gcc 10
  • 53e0826: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • a37b856: 8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  • b7bda28: 8325150: (tz) Update Timezone Data to 2024a
  • ae516a3: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  • 9bd600c: 8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  • e926edc: 8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  • 9aabf22: 8270517: Add Zero support for LoongArch
  • dce5300: 8168518: rcache interop with krb5-1.15

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@mrserb Pushed as commit a798523.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8025439 branch February 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants