8069389: CompilerOracle prefix wildcarding is broken for long strings

[wkia]

Clean backport.

I've just found that the issue occurs even with short strings like "*123*", see my screenshot attached to JDK-8069389. This can be reproduced currently with "slowdebug" build on my Ubuntu 22.04 + gcc-9.5.0, however I believe we cannot rely on it isn't reproduced with "release" now.

Anyway, it wasn't good to use "strcpy" with overlapped buffers, because strcpy's docs says "The behavior is undefined if the strings overlap." So, I believe it should be fixed in jdk8 as well.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8069389 needs maintainer approval

Issue

• JDK-8069389: CompilerOracle prefix wildcarding is broken for long strings (Bug - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/446/head:pull/446
$ git checkout pull/446

Update a local copy of the PR:
$ git checkout pull/446
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 446

View PR using the GUI difftool:
$ git pr show -t 446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/446.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full (fb23dd60)
• 01: Full (b2ae4d2a)
• 00: Full (9880ca85)

[openjdk]

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[wkia]

/approval Clean backport

[openjdk]

@wkia usage: /approval [<id>] (request|cancel) [<text>]

[wkia]

/approval request Clean backport

[openjdk]

@wkia
8069389: The approval request has been created successfully.

[openjdk]

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[gnu-andrew]

Does the new test pass on 8u?

[wkia]

@gnu-andrew Yes, it passed.

However, as just a note, my opinion is a test doesn't make sense here since we're trying to emulate a failure case which is actually caused by undefined behaviour. UB cannot be predicted or tested, and it may change depending on platform, versions, etc.

Anyway, the test passed.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8069389: CompilerOracle prefix wildcarding is broken for long strings

Replace strcpy with memmove

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• c1c8064: 8320005: Allow loading of shared objects with .a extension on AIX
• d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately
• 1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
• a4b40e8: 8291226: Create Test Cases to cover scenarios for JDK-8278067
• af033c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test
• 5968b15: 8328809: [8u] Problem list some CA tests
• e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• 5256587: Merge
• 04ccdbf: 8321408: Add Certainly roots R1 and E1
• ... and 13 more: https://git.openjdk.org/jdk8u-dev/compare/824dbfbc98c12811dc30a7391ae51c0f71158d3e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[gnu-andrew]

Verified clean.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8069389: The approval request has been approved.

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version fb23dd6) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit cde8aca.
Since your change was applied there have been 23 commits pushed to the master branch:

• c1c8064: 8320005: Allow loading of shared objects with .a extension on AIX
• d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately
• 1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
• a4b40e8: 8291226: Create Test Cases to cover scenarios for JDK-8278067
• af033c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test
• 5968b15: 8328809: [8u] Problem list some CA tests
• e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
• 5256587: Merge
• 04ccdbf: 8321408: Add Certainly roots R1 and E1
• ... and 13 more: https://git.openjdk.org/jdk8u-dev/compare/824dbfbc98c12811dc30a7391ae51c0f71158d3e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @wkia Pushed as commit cde8aca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.