8326110: [8u] The Marlin tests should be updated after JDK-8241307

[mrserb]

The tests are updated to force the MarlinRenderingEngine.

@bourgesl please take a look.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326110 needs maintainer approval

Issue

• JDK-8326110: [8u] The Marlin tests should be updated after JDK-8241307 (Bug - P4 - Approved)

Reviewers

• Laurent Bourgès (@bourgesl - Committer) Review applies to 0ae5ee57
• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447
$ git checkout pull/447

Update a local copy of the PR:
$ git checkout pull/447
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 447

View PR using the GUI difftool:
$ git pr show -t 447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/447.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 06: Full - Incremental (7f6ed435)
• 05: Full - Incremental (f7507e15)
• 04: Full - Incremental (97d06843)
• 03: Full - Incremental (725633e9)
• 02: Full - Incremental (6d22db51)
• 01: Full - Incremental (cfbe4764)
• 00: Full (0ae5ee57)

[bourgesl]

LGTM 😉

[bourgesl]

Maybe 2 unit tests do not need using the marlin engine to be enabled

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326110: [8u] The Marlin tests should be updated after JDK-8241307

Reviewed-by: phh, andrew, lbourges

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[bourgesl]

LGTM

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Seems sensible to me.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8326110: The approval request has been approved.

[bourgesl]

Thanks, andrew

[mrserb]

/integrate

[openjdk]

Going to push as commit 00d2542.

[openjdk]

@mrserb Pushed as commit 00d2542.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[gnu-andrew]

Moved to 8u452; see https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html