-
Notifications
You must be signed in to change notification settings - Fork 159
8291226: Create Test Cases to cover scenarios for JDK-8278067 #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into |
Webrevs
|
This backport pull request has now been updated with issue from the original commit. |
The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again. |
Did you run the tests? If yes, what was the result? |
…ort-JDK-8291226
@dhanalla This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout Backport-JDK-8291226
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@dhanalla this pull request can not be integrated into git checkout Backport-JDK-8291226
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
|
/integrate |
/sponsor |
Going to push as commit a4b40e8.
Your commit was automatically rebased without conflicts. |
Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
Clean backport from JDK11u patch.
Test performed:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/453/head:pull/453
$ git checkout pull/453
Update a local copy of the PR:
$ git checkout pull/453
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/453/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 453
View PR using the GUI difftool:
$ git pr show -t 453
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/453.diff
Webrev
Link to Webrev Comment