Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291638: Keep-Alive timeout of 0 should close connection immediately #454

Closed
wants to merge 14 commits into from

Conversation

dhanalla
Copy link

@dhanalla dhanalla commented Feb 21, 2024

Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec

A clean backport from JDK11u patch, excluding one version-specific API, "!OptionalInt::isPresent() vs OptionalInt::isEmpty()".

Test performed:

  1. JTreg jdk_tier1, hotspot_tier1
  2. The backported test case in this PR passed.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8291638 needs maintainer approval

Issue

  • JDK-8291638: Keep-Alive timeout of 0 should close connection immediately (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/454/head:pull/454
$ git checkout pull/454

Update a local copy of the PR:
$ git checkout pull/454
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 454

View PR using the GUI difftool:
$ git pr show -t 454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/454.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into pr/453 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec 8291638: Keep-Alive timeout of 0 should close connection immediately Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 21, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR is also trying to bring in JDK-8291637 without its associated test case.

I would suggest opening a separate PR for that backport and making this one dependent on it instead. This change should then be close to clean.

@dhanalla
Copy link
Author

dhanalla commented Mar 4, 2024

It looks like this PR is also trying to bring in JDK-8291637 without its associated test case.

I would suggest opening a separate PR for that backport and making this one dependent on it instead. This change should then be close to clean.

Thanks @gnu-andrew for reviewing this PR.
I created backport #466 and made #453 dependent on the new PR #466 in accordance with the backport order in JDK11U.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@dhanalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8291638: Keep-Alive timeout of 0 should close connection immediately

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/453 to master April 5, 2024 17:01
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout Backport_JDK-8291638
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@dhanalla this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout Backport_JDK-8291638
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @dhanalla This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 5, 2024
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Apr 5, 2024
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Apr 8, 2024
@dhanalla
Copy link
Author

dhanalla commented Apr 8, 2024

Looks good.

Thanks @jerboaa for reviewing this PR. I've added a JDK8 patch request to the bug as the next step.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 8, 2024
@dhanalla
Copy link
Author

dhanalla commented Apr 8, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@dhanalla
Your change (at version e2fc39d) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 8, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

Going to push as commit d0d9a15.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024
@openjdk openjdk bot closed this Apr 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@jerboaa @dhanalla Pushed as commit d0d9a15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants