Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326686: Bump update version of OpenJDK: 8u422 #456

Closed
wants to merge 1 commit into from

Conversation

gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Feb 26, 2024

Rampdown for 8u412 has begun. 8u-dev needs to transition to 8u422.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8326686 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8326686: Bump update version of OpenJDK: 8u422 (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/456/head:pull/456
$ git checkout pull/456

Update a local copy of the PR:
$ git checkout pull/456
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 456

View PR using the GUI difftool:
$ git pr show -t 456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/456.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2024
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlbridge
Copy link

mlbridge bot commented Feb 26, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

/approval request Necessary process bump to start new release cycle.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@gnu-andrew
8326686: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 26, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Feb 26, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@jerboaa
8326686: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326686: Bump update version of OpenJDK: 8u422

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 26, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 0f20f67.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@gnu-andrew Pushed as commit 0f20f67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants