8298887: On the latest macOS+XCode the Robot API may report wrong colors

[mrserb]

Hi all,

This pull request contains a backport of commit ceb6793b from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee.

This patch is needed to support XCode 14.2+

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8298887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/457/head:pull/457
$ git checkout pull/457

Update a local copy of the PR:
$ git checkout pull/457
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/457/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 457

View PR using the GUI difftool:
$ git pr show -t 457

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/457.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

The patch is mostly clean. The only change is a list of bugs in the CheckCommonColors.java - the JDK-8211999 is not present in jdk8u.

[mlbridge]

Webrevs

• 00: Full (e56360b5)

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

• 7c13bd8: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
• 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
• 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
• 89697c3: 8334653: ISO 4217 Amendment 177 Update
• 9a426ad: 8318951: Additional negative value check in JPEG decoding
• aa44346: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
• fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
• 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
• 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
• 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
• ... and 91 more: https://git.openjdk.org/jdk8u-dev/compare/d7ad5bf5583bed023558c5bb9eaba12ded4987e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[gnu-andrew]

Patch looks good.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8298887: The approval request has been approved.

[mrserb]

/integrate

[openjdk]

Going to push as commit e32d62e.
Since your change was applied there have been 102 commits pushed to the master branch:

• 8b0fedc: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
• 7c13bd8: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
• 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
• 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
• 89697c3: 8334653: ISO 4217 Amendment 177 Update
• 9a426ad: 8318951: Additional negative value check in JPEG decoding
• aa44346: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
• fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
• 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
• 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
• ... and 92 more: https://git.openjdk.org/jdk8u-dev/compare/d7ad5bf5583bed023558c5bb9eaba12ded4987e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit e32d62e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.