Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8166140: C1: Possible integer overflow in LIRGenerator::generate_address on several platforms #46

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 22, 2022

I would like to backport this patch to 8u for parity with Oracle 8u331.

Bug: https://bugs.openjdk.java.net/browse/JDK-8166140
Patch: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/f6c1ea29110e

The patch does not apply cleanly:

  1. ppc does not have compiler port in 8u.
  2. Changes for LIRGenerator::emit_array_address() in c1_LIRGenerator_x86.cpp is obsoleted by JDK-8272014

Original code review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2022-January/014517.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8166140: C1: Possible integer overflow in LIRGenerator::generate_address on several platforms ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/46/head:pull/46
$ git checkout pull/46

Update a local copy of the PR:
$ git checkout pull/46
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/46/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 46

View PR using the GUI difftool:
$ git pr show -t 46

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/46.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2022

@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@theRealAph
Copy link
Contributor

That looks right. I've just gone through the Assembler entry points to make sure that all of them really do take a 64-bit integer type. There has been some churn in this area.

This looks OK:

Assembler::operand_valid_for_add_sub_immediate((long imm)
Address::offset_ok_for_immed((int64_t offset, uint shift)

And AFAICS there's no truncation to int anywhere in the path. But please check too.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2022

@zhengyu123 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2022

@zhengyu123 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
2 participants