Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326529: JFR: Test for CompilerCompile events fails due to time out #463

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Feb 28, 2024

This is a backport of openjdk/jdk@4dd6c44

This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326529 needs maintainer approval

Issue

  • JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/463/head:pull/463
$ git checkout pull/463

Update a local copy of the PR:
$ git checkout pull/463
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 463

View PR using the GUI difftool:
$ git pr show -t 463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/463.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@roberttoyonaga roberttoyonaga changed the title 8326987: JFR: Test for CompilerCompile events fails due to time out 8326529: JFR: Test for CompilerCompile events fails due to time out Feb 28, 2024
@roberttoyonaga roberttoyonaga changed the title 8326529: JFR: Test for CompilerCompile events fails due to time out Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 Feb 28, 2024
@openjdk openjdk bot changed the title Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 8326529: JFR: Test for CompilerCompile events fails due to time out Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 28, 2024
@roberttoyonaga roberttoyonaga marked this pull request as ready for review February 28, 2024 21:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@phohensee
Copy link
Member

Please backport to 22u, 21u, 17u, and 11u before proceeding with 8u.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants