Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256152: tests fail because of ambiguous method resolution #468

Closed

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Mar 18, 2024

Backport to fix test build failures.

Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from org.testng.Assert. (probably methods were added there, which introduced ambiguity)

After dealing with different test path on 8, patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8256152 needs maintainer approval

Issue

  • JDK-8256152: tests fail because of ambiguous method resolution (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/468/head:pull/468
$ git checkout pull/468

Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 468

View PR using the GUI difftool:
$ git pr show -t 468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/468.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256152: tests fail because of ambiguous method resolution

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 6ba9f58: 8278067: Make HttpURLConnection default keep alive timeout configurable
  • 147b418: 8327440: Fix "bad source file" error during beaninfo generation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 646c20022c73258bebf7c55b3e1992b62f5de042 8256152: tests fail because of ambiguous method resolution Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 18, 2024
@zzambers
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@zzambers This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Mar 18, 2024

Webrevs

@zzambers
Copy link
Contributor Author

Tested locally with jtreg, which has shown failures (6+1). Problematic tests passed with changeset applied (failed without).

@zzambers
Copy link
Contributor Author

GHA tier1 tests: OK

  • jdk/tier1 failures (CAInterop.java) are not related to this changeset, see JDK-8324583
  • hotspot/tier1 failure on linux x86 (timeout of TestGCId.java) is unrelated to this changeset

@zzambers
Copy link
Contributor Author

/approval request fixes few test failures when newer jtreg is used, clean, only affects tests, tested

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@zzambers
8256152: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 18, 2024
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit d23bbdd.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 6ba9f58: 8278067: Make HttpURLConnection default keep alive timeout configurable
  • 147b418: 8327440: Fix "bad source file" error during beaninfo generation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@zzambers Pushed as commit d23bbdd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant