-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256152: tests fail because of ambiguous method resolution #468
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/clean |
@zzambers This backport pull request is now marked as clean |
|
Tested locally with jtreg, which has shown failures (6+1). Problematic tests passed with changeset applied (failed without). |
GHA tier1 tests: OK
|
/approval request fixes few test failures when newer jtreg is used, clean, only affects tests, tested |
/integrate |
Going to push as commit d23bbdd.
Your commit was automatically rebased without conflicts. |
Backport to fix test build failures.
Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from
org.testng.Assert
. (probably methods were added there, which introduced ambiguity)After dealing with different test path on 8, patch applies cleanly.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/468/head:pull/468
$ git checkout pull/468
Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/468/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 468
View PR using the GUI difftool:
$ git pr show -t 468
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/468.diff
Webrev
Link to Webrev Comment