Skip to content

Conversation

@ktakakuri
Copy link
Member

@ktakakuri ktakakuri commented Apr 25, 2022

I would like to backport
8248876: LoadObject with bad base address created for exec file on linux.

The original patch does not apply cleanly to 8u, and this is a clean backport from 11u.

Testing:
build on Linux x86_64
tier1 on Linux x86_64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8248876: LoadObject with bad base address created for exec file on linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/47/head:pull/47
$ git checkout pull/47

Update a local copy of the PR:
$ git checkout pull/47
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/47/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 47

View PR using the GUI difftool:
$ git pr show -t 47

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/47.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9d59dec200490f11bfc1c661b30f10c7edee3a6d 8248876: LoadObject with bad base address created for exec file on linux Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

@ktakakuri
Copy link
Member Author

Could anyone review this backport please?

@phohensee
Copy link
Member

/clean

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the backport from 11u is clean.

@openjdk
Copy link

openjdk bot commented May 4, 2022

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248876: LoadObject with bad base address created for exec file on linux

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated clean Identical backport; no merge resolution required labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@phohensee This backport pull request is now marked as clean

@phohensee
Copy link
Member

Pref-submit build failures appear to be due to incompatible compilers.

@ktakakuri
Copy link
Member Author

@phohensee
Thank you for your review.
I am not sure if I should continue to integrate.
Is there any other work that needs to be done?

@phohensee
Copy link
Member

Yes. You need to tag the JBS issue with 'jdk8u-fix-request' and wait for a maintainer to approve it by adding the 'jdk8u-fix-yes' tag. Once that's done, you can integrate it. I'll sponsor if you like.

@ktakakuri
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@ktakakuri
Your change (at version d0b16f0) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

Got the approval. Presubmit failures appear to be an infrastructure problem.

@openjdk
Copy link

openjdk bot commented May 19, 2022

Going to push as commit 3e0eb09.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 19, 2022
@openjdk openjdk bot closed this May 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 19, 2022
@openjdk
Copy link

openjdk bot commented May 19, 2022

@phohensee @ktakakuri Pushed as commit 3e0eb09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

/sponsor

Got the approval. Presubmit failures appear to be an infrastructure problem.

This has been fixed by JDK-8284772 for some time. For future such PRs, I'd suggest a rebase so the tests are re-run.

@ktakakuri ktakakuri deleted the 8248876 branch June 22, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants