-
Notifications
You must be signed in to change notification settings - Fork 171
8248876: LoadObject with bad base address created for exec file on linux #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
Could anyone review this backport please? |
|
/clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the backport from 11u is clean.
|
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@phohensee This backport pull request is now marked as clean |
|
Pref-submit build failures appear to be due to incompatible compilers. |
|
@phohensee |
|
Yes. You need to tag the JBS issue with 'jdk8u-fix-request' and wait for a maintainer to approve it by adding the 'jdk8u-fix-yes' tag. Once that's done, you can integrate it. I'll sponsor if you like. |
|
/integrate |
|
@ktakakuri |
|
/sponsor Got the approval. Presubmit failures appear to be an infrastructure problem. |
|
Going to push as commit 3e0eb09.
Your commit was automatically rebased without conflicts. |
|
@phohensee @ktakakuri Pushed as commit 3e0eb09. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This has been fixed by JDK-8284772 for some time. For future such PRs, I'd suggest a rebase so the tests are re-run. |
I would like to backport
8248876: LoadObject with bad base address created for exec file on linux.
The original patch does not apply cleanly to 8u, and this is a clean backport from 11u.
Testing:
build on Linux x86_64
tier1 on Linux x86_64
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/47/head:pull/47$ git checkout pull/47Update a local copy of the PR:
$ git checkout pull/47$ git pull https://git.openjdk.java.net/jdk8u-dev pull/47/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 47View PR using the GUI difftool:
$ git pr show -t 47Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/47.diff