Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317507: C2 compilation fails with "Exceeded _node_regs array" #470

Closed
wants to merge 1 commit into from

Conversation

martinuy
Copy link
Contributor

@martinuy martinuy commented Mar 22, 2024

Hi,

I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the Compiler reference is passed by parameter instead of taken from the Compile::current method. I ran and debugged the test to make sure that it is triggering the faulty behavior.

Thanks,
Martin.-


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317507 needs maintainer approval

Issue

  • JDK-8317507: C2 compilation fails with "Exceeded _node_regs array" (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/470/head:pull/470
$ git checkout pull/470

Update a local copy of the PR:
$ git checkout pull/470
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 470

View PR using the GUI difftool:
$ git pr show -t 470

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/470.diff

Webrev

Link to Webrev Comment

Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back mbalao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@martinuy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317507: C2 compilation fails with "Exceeded _node_regs array"

Reviewed-by: roland, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 5256587: Merge
  • 04ccdbf: 8321408: Add Certainly roots R1 and E1
  • 78c0afa: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 039fb8a: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • d23bbdd: 8256152: tests fail because of ambiguous method resolution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

@martinuy
Copy link
Contributor Author

GHA test failures look unrelated to this change.

Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

⚠️ @martinuy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@martinuy
Copy link
Contributor Author

/approval request 8u is affected by this bug so I'd like to request approval for a backport. The 17u patch applied with minor changes, the test works fine and risk is minimal.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@martinuy
8317507: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 22, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the signature of this generated function is void MachNode::fill_new_machnode( MachNode* node, Compile* C) in 8u. In later JDKs, this was changed to void MachNode::fill_new_machnode(MachNode* node) by JDK-8054033: "Remove unused references to Compile*" so a Compile instance needs to be obtained from Compile::current() there.

Change itself looks ok. As with the 11u PR, the PR title needs to be "Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65" so Skara will pick this up as a backport and configure things appropriately.

@martinuy martinuy changed the title 8317507: C2 compilation fails with "Exceeded _node_regs array" Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65 Mar 27, 2024
@openjdk openjdk bot changed the title Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65 8317507: C2 compilation fails with "Exceeded _node_regs array" Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 27, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@gnu-andrew
8317507: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 27, 2024
@martinuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

Going to push as commit e72ea2d.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 5256587: Merge
  • 04ccdbf: 8321408: Add Certainly roots R1 and E1
  • 78c0afa: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 039fb8a: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • d23bbdd: 8256152: tests fail because of ambiguous method resolution

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2024
@openjdk openjdk bot closed this Mar 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@martinuy Pushed as commit e72ea2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants