Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328809: [8u] Problem list some CA tests #471

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Mar 22, 2024

Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328809 needs maintainer approval

Issue

  • JDK-8328809: [8u] Problem list some CA tests (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/471/head:pull/471
$ git checkout pull/471

Update a local copy of the PR:
$ git checkout pull/471
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 471

View PR using the GUI difftool:
$ git pr show -t 471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/471.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8328809: [8u] Problem list some CA tests

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 5256587: Merge
  • 04ccdbf: 8321408: Add Certainly roots R1 and E1
  • 78c0afa: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 039fb8a: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • d23bbdd: 8256152: tests fail because of ambiguous method resolution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

@jerboaa jerboaa changed the title 8328809: [8u] Problem list Google root CA tests 8328809: [8u] Problem list some CA tests Mar 22, 2024
jdk/test/ProblemList.txt Outdated Show resolved Hide resolved
@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 25, 2024

GHA failure on 32 bit linux of gc/6581734/Test6581734.java is intermittent and unrelated.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Note that JDK-8328825 should resolve the GTS ones and is already backported as far as 11u (just awaiting your approval there).

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew gnu-andrew mentioned this pull request Mar 27, 2024
3 tasks
@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 27, 2024

/approval request Please allow this problem listing for OpenJDK 8u as it generates significant test noise. I'll follow up with a backport of JDK-8328825 and remove the problem listing again. But for now lets get GHA tests cleaner! Low risk. Problem listing only.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@jerboaa
8328809: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 27, 2024
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@gnu-andrew
8328809: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 27, 2024
@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 27, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

Going to push as commit 5968b15.
Since your change was applied there have been 6 commits pushed to the master branch:

  • e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 5256587: Merge
  • 04ccdbf: 8321408: Add Certainly roots R1 and E1
  • 78c0afa: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 039fb8a: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  • d23bbdd: 8256152: tests fail because of ambiguous method resolution

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2024
@openjdk openjdk bot closed this Mar 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@jerboaa Pushed as commit 5968b15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants