8320005: Allow loading of shared objects with .a extension on AIX #473

suchismith1993 · 2024-03-25T18:20:49Z

Hi all,

This pull request contains a backport of commit e85355ad from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.

Thanks!

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8320005 needs maintainer approval

Issue

JDK-8320005: Allow loading of shared objects with .a extension on AIX (Bug - P4 - Approved)

Reviewers

Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/473/head:pull/473
$ git checkout pull/473

Update a local copy of the PR:
$ git checkout pull/473
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/473/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 473

View PR using the GUI difftool:
$ git pr show -t 473

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/473.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-25T18:21:15Z

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-25T18:22:13Z

@suchismith1993 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320005: Allow loading of shared objects with .a extension on AIX

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-03-25T18:22:29Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-03-25T18:25:52Z

Webrevs

jerboaa · 2024-04-05T14:38:46Z

hotspot/src/os/aix/vm/os_aix.cpp

@@ -1452,7 +1452,7 @@ bool os::dll_address_to_library_name(address addr, char* buf,

 // Loads .dll/.so and in case of error it checks if .dll/.so was built
 // for the same architecture as Hotspot is running on.
-void *os::dll_load(const char *filename, char *ebuf, int ebuflen) {
+static void* dll_load(const char *filename, char *ebuf, int ebuflen) {


Are you sure this is correct? The JDK 11u change renamed this to dll_load_library. Does this even work?

@jerboaa Still working on it. 11 and 17 backports were very much clean and had no issues. For some reason jdk8 compilation is failing in my local. So hopefully i will get it working soon.

@jerboaa thanks for the catch. That might be causing it. I had to make changes in a file located in different location , so the backport didn't apply clean.

@jerboaa I see the certificate tests failing in the tests. Are these due to some other issue ? I do not see how my fix would cause a certificate issue.

@suchismith1993 Please merge latest master, those tests should be on the problem list by now. See https://bugs.openjdk.org/browse/JDK-8328809

openjdk · 2024-04-08T08:43:54Z

@suchismith1993 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

jerboaa · 2024-04-08T13:12:21Z

gc/logging/TestGCId.java fails intermittently on x86 (32 bit). Unrelated to this patch.

jerboaa

Looks fine.

openjdk · 2024-04-08T13:13:44Z

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

suchismith1993 · 2024-04-08T16:17:51Z

/approval request This back port is required to handle dynamic libraries of AIX.

openjdk · 2024-04-08T16:18:59Z

@suchismith1993
8320005: The approval request has been created successfully.

suchismith1993 · 2024-04-08T17:39:31Z

/integrate

openjdk · 2024-04-08T17:39:50Z

@suchismith1993
Your change (at version 79f53bb) is now ready to be sponsored by a Committer.

jerboaa · 2024-04-08T18:21:05Z

/sponsor

openjdk · 2024-04-08T18:22:20Z

Going to push as commit c1c8064.
Since your change was applied there has been 1 commit pushed to the master branch:

d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately

Your commit was automatically rebased without conflicts.

openjdk · 2024-04-08T18:22:29Z

@jerboaa @suchismith1993 Pushed as commit c1c8064.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

gnu-andrew · 2024-04-10T14:28:12Z

Hmmm, this seems to have travelled from trunk to 8u very quickly. This change is not in any released version as yet.

I think it would have been better to wait until at least the release of 22.0.2. I guess at least the change is isolated to AIX only, but I would make sure this is tested well before the July releases.

suchismith1993 · 2024-04-15T16:13:37Z

Hmmm, this seems to have travelled from trunk to 8u very quickly. This change is not in any released version as yet.

I think it would have been better to wait until at least the release of 22.0.2. I guess at least the change is isolated to AIX only, but I would make sure this is tested well before the July releases.

Hi @gnu-andrew What is the usual timeline for a fix to go to the release branch from u-dev branch ?
I am not sure how it went. I just did the usual backport as i did for 11 and 17.

openjdk bot changed the title ~~Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab~~ 8320005: Allow loading of shared objects with .a extension on AIX Mar 25, 2024

openjdk bot added backport rfr Pull request is ready for review labels Mar 25, 2024

jerboaa reviewed Apr 5, 2024

View reviewed changes

suchismith1993 added 3 commits April 8, 2024 08:28

Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab

12c48b3

Same logic different file

89b2824

rename method

79f53bb

suchismith1993 force-pushed the backport-suchismith1993-e85355ad branch from beb289f to 79f53bb Compare April 8, 2024 08:42

jerboaa approved these changes Apr 8, 2024

View reviewed changes

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 8, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 8, 2024

openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024

openjdk bot closed this Apr 8, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2024

openjdk bot removed the sponsor Pull request is ready to be sponsored label Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8320005: Allow loading of shared objects with .a extension on AIX #473

8320005: Allow loading of shared objects with .a extension on AIX #473

suchismith1993 commented Mar 25, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 25, 2024

openjdk bot commented Mar 25, 2024 •

edited

Loading

openjdk bot commented Mar 25, 2024

mlbridge bot commented Mar 25, 2024 •

edited

Loading

jerboaa Apr 5, 2024

suchismith1993 Apr 5, 2024

suchismith1993 Apr 5, 2024

suchismith1993 Apr 5, 2024

jerboaa Apr 8, 2024 •

edited

Loading

openjdk bot commented Apr 8, 2024

jerboaa commented Apr 8, 2024

jerboaa left a comment

openjdk bot commented Apr 8, 2024

suchismith1993 commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

suchismith1993 commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

jerboaa commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

gnu-andrew commented Apr 10, 2024

suchismith1993 commented Apr 15, 2024

8320005: Allow loading of shared objects with .a extension on AIX #473

8320005: Allow loading of shared objects with .a extension on AIX #473

Conversation

suchismith1993 commented Mar 25, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 25, 2024

openjdk bot commented Mar 25, 2024 • edited Loading

openjdk bot commented Mar 25, 2024

mlbridge bot commented Mar 25, 2024 • edited Loading

Webrevs

jerboaa Apr 5, 2024

Choose a reason for hiding this comment

suchismith1993 Apr 5, 2024

Choose a reason for hiding this comment

suchismith1993 Apr 5, 2024

Choose a reason for hiding this comment

suchismith1993 Apr 5, 2024

Choose a reason for hiding this comment

jerboaa Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

openjdk bot commented Apr 8, 2024

jerboaa commented Apr 8, 2024

jerboaa left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 8, 2024

suchismith1993 commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

suchismith1993 commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

jerboaa commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

openjdk bot commented Apr 8, 2024

gnu-andrew commented Apr 10, 2024

suchismith1993 commented Apr 15, 2024

suchismith1993 commented Mar 25, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 25, 2024 •

edited

Loading

mlbridge bot commented Mar 25, 2024 •

edited

Loading

jerboaa Apr 8, 2024 •

edited

Loading