8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

[phohensee]

This is a replacement for #393 and is identical to it.

Follow-on bug fix for JDK-8304074 backport. Unclean backport from 11u, see openjdk/jdk11u-dev#2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8313081 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 (Bug - P4 - Approved)

Reviewers

• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/475/head:pull/475
$ git checkout pull/475

Update a local copy of the PR:
$ git checkout pull/475
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 475

View PR using the GUI difftool:
$ git pr show -t 475

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/475.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (86ca4956)

[simonis]

Still trivial and still good :)

[phohensee]

GHA test failures appear unrelated.

[phohensee]

/approval request Almost clean backport of a follow-on fix for the JDK-8304074 backport at #392. In production at Amazon for almost 5 months.

[openjdk]

@phohensee
8313081: The approval request has been updated successfully.

[phohensee]

/integrate

[openjdk]

Going to push as commit af033c6.
Since your change was applied there has been 1 commit pushed to the master branch:

• 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit af033c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.