Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 #475

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Mar 27, 2024

This is a replacement for #393 and is identical to it.

Follow-on bug fix for JDK-8304074 backport. Unclean backport from 11u, see openjdk/jdk11u-dev#2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8313081 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/475/head:pull/475
$ git checkout pull/475

Update a local copy of the PR:
$ git checkout pull/475
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 475

View PR using the GUI difftool:
$ git pr show -t 475

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/475.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2024

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport approval rfr Pull request is ready for review labels Mar 27, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2024

Webrevs

Copy link
Member

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still trivial and still good :)

@phohensee
Copy link
Member Author

GHA test failures appear unrelated.

@phohensee
Copy link
Member Author

/approval request Almost clean backport of a follow-on fix for the JDK-8304074 backport at #392. In production at Amazon for almost 5 months.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@phohensee
8313081: The approval request has been updated successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 5, 2024
@phohensee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit af033c6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@phohensee Pushed as commit af033c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants