8235834: IBM-943 charset encoder needs updating

[psawant19]

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8235834 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8235834: IBM-943 charset encoder needs updating (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476
$ git checkout pull/476

Update a local copy of the PR:
$ git checkout pull/476
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 476

View PR using the GUI difftool:
$ git pr show -t 476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/476.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @psawant19, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user psawant19" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[psawant19]

This contribution is on behalf of my employer, IBM, which is a corporate OCA signatory.

[psawant19]

/covered

[openjdk]

@psawant19 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235834: IBM-943 charset encoder needs updating

Apply 34B003AF.RPMAP130 definition into encoder

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[psawant19]

/covered

[bridgekeeper]

Already processed the covered command

[psawant19]

/covered

[bridgekeeper]

Already processed the covered command

[psawant19]

Closing this PR as my OCA verification is taking too long to approve.
Opened another PR by a different contributor:- #480.

[psawant19]

/covered

[bridgekeeper]

You are already a known contributor!

[psawant19]

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 05: Full - Incremental (bde1d37a)
• 04: Full - Incremental (11a3e6a2)
• 03: Full - Incremental (15880de4)
• 02: Full - Incremental (670b83d5)
• 01: Full - Incremental (591b1157)
• 00: Full (a5e2a5de)

[psawant19]

@gnu-andrew, @mrserb Could you please review this PR.

[offamitkumar]

Hi @psawant19 ,
This PR doesn't make any sense if #480 is in review. Please close one of them.

[jerboaa]

The test fails:

/disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
            if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
                 ^
  symbol:   variable Arrays
  location: class TestIBMBugs
1 error
result: Failed. Compilation failed: Compilation failed

Adding the import should fix it.

Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!

[psawant19]

@jerboaa,
I have fixed the compilation error and GHAs are enabled on this repo.
IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm

Attaching test evidences for the bug fix with before and after screenshots.

Before fix:

After fix:

[jerboaa]

@psawant19 Thanks. Please also show that the sun/nio/cs jtreg tests are passing.

[jerboaa]

This looks OK.

[jerboaa]

I have fixed the compilation error and GHAs are enabled on this repo.

Please merge lastest master into your branch, which should make the certinga CA tests failure go away.

[openjdk]

⚠️ @psawant19 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[psawant19]

@jerboaa,
There is still 1 pre-test failing that is because these below packages doesn't exist at this location.

• https://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
• https://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages

Is the PR good to go for maintainer approval?

[offamitkumar]

Is the PR good to go for maintainer approval?

Yes, use /approval request <your reason> to apply for the approval. Please give justification why you want to backport the changes, what testing you have done and what is risk (low/high). In this case it should be low.

[psawant19]

/approval request This back port is required to display Japanese locale which uses IBM943 charset.
The fix is tested in a linux environment and the test case passes as mentioned in the screenshot above.

[openjdk]

@psawant19
8235834: The approval request has been created successfully.

[jerboaa]

The follow-up, JDK-8239965, needs backporting too. Please do that so that I can approve them as a unit.

[psawant19]

This is the PR (#500) created for backporting JDK-8239965.

[psawant19]

/integrate

[openjdk]

@psawant19
Your change (at version bde1d37) is now ready to be sponsored by a Committer.

[openjdk]

⚠️ @psawant19 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout IBM943-support-backport-1b9251
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[jerboaa]

/sponsor

[openjdk]

Going to push as commit ab408de.
Since your change was applied there has been 1 commit pushed to the master branch:

• b3308b1: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @psawant19 Pushed as commit ab408de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.