Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Apr 2, 2024

Hi all,

This pull request contains a backport of commit 2fa6eac4 from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Bob Vandette on 12 Jun 2018 and was reviewed by David Holmes, Mikhailo Seledtsov and Robbin Ehn.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8203691 needs maintainer approval

Issue

  • JDK-8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/477/head:pull/477
$ git checkout pull/477

Update a local copy of the PR:
$ git checkout pull/477
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 477

View PR using the GUI difftool:
$ git pr show -t 477

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/477.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2fa6eac464048176087092c91c8430781ab15301 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Apr 2, 2024
@mrserb
Copy link
Member Author

mrserb commented Apr 2, 2024

/clean The patch is identical to the patch in jdk11u-dev

@mrserb mrserb marked this pull request as ready for review April 2, 2024 15:41
@openjdk openjdk bot added rfr Pull request is ready for review clean Identical backport; no merge resolution required labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Apr 2, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@jerboaa
8203691: There is no maintainer approval request for this issue.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 2, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Apr 5, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@jerboaa
8203691: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 5, 2024
@mrserb
Copy link
Member Author

mrserb commented Apr 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

Going to push as commit 1db6a76.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a4b40e8: 8291226: Create Test Cases to cover scenarios for JDK-8278067
  • af033c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2024
@openjdk openjdk bot closed this Apr 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@mrserb Pushed as commit 1db6a76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants