8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary #478

ianrichr · 2024-04-02T16:48:49Z

sun/security/krb5/auto/ReplayCacheTestProc.java fails on jdk8u-412 due to a compilation error. This is because the classpath is being set incorrectly by the @library annotation.

TEST: sun/security/krb5/auto/ReplayCacheTestProc.java
TEST JDK: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image

ACTION: compile -- Failed. Compilation failed: Compilation failed
REASON: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
TIME:   0.752 seconds
messages:
command: compile -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
reason: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
Mode: agentvm
Agent id: 1
elapsed time (seconds): 0.752
configuration:
Boot Layer (javac runtime environment)
  class path: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
              /local/home/ianrichr/openjdk/jtreg/lib/javatest.jar
              /local/home/ianrichr/openjdk/jtreg/lib/jtreg.jar

javac compilation environment
  source path: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
               /local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary
  class path:  /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
               /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto
               /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar

rerun:
cd /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/scratch/0 && \
HOME=/home/ianrichr \
LANG=en_US.UTF-8 \
PATH=/bin:/usr/bin:/usr/sbin \
    /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac \
        -J-ea \
        -J-esa \
        -J-Xmx512m \
        -J-Dtest.vm.opts='-ea -esa -Xmx512m' \
        -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx512m' \
        -J-Dtest.compiler.opts= \
        -J-Dtest.java.opts= \
        -J-Dtest.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
        -J-Dcompile.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
        -J-Dtest.timeout.factor=4.0 \
        -J-Dtest.root=/local/home/ianrichr/openjdk/jdk8u/jdk/test \
        -J-Dtest.name=sun/security/krb5/auto/ReplayCacheTestProc.java \
        -J-Dtest.file=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java \
        -J-Dtest.src=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto \
        -J-Dtest.src.path=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary \
        -J-Dtest.classes=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto \
        -J-Dtest.class.path=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/java/security/testlibrary \
        -J-Dtest.class.path.prefix=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto \
        -d /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto \
        -sourcepath /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary \
        -classpath /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar \
        -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
direct:
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:46: error: package jdk.test.lib does not exist
import jdk.test.lib.Platform;
                   ^
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:138: error: cannot find symbol
                if (Platform.isOSX() || Platform.isWindows()) {
                    ^
  symbol:   variable Platform
  location: class ReplayCacheTestProc
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:138: error: cannot find symbol
                if (Platform.isOSX() || Platform.isWindows()) {
                                        ^
  symbol:   variable Platform
  location: class ReplayCacheTestProc
Note: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/KDC.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors

TEST RESULT: Failed. Compilation failed: Compilation failed
--------------------------------------------------
Test results: failed: 1
Report written to /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTreport/html/report.html
Results written to /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork
Error: Some tests failed or other problems occurred.
Summary: jdk_adhoc
FAILED: sun/security/krb5/auto/ReplayCacheTestProc.java

Appending /test/lib to the @library annotation allows the compilation to succeed and the test passes.

Passed: sun/security/krb5/auto/ReplayCacheTestProc.java
Test results: passed: 1

This was introduced with this PR/issue https://bugs.openjdk.org/browse/JDK-8168518 when the import jdk.test.lib.Platform; was added to the test file.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8329544 needs maintainer approval

Issue

JDK-8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary (Bug - P4 - Approved)

Reviewers

Aleksey Shipilev (@shipilev - Reviewer)
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/478/head:pull/478
$ git checkout pull/478

Update a local copy of the PR:
$ git checkout pull/478
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 478

View PR using the GUI difftool:
$ git pr show -t 478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/478.diff

Webrev

Link to Webrev Comment

…estProc.java

bridgekeeper · 2024-04-02T16:49:25Z

👋 Welcome back imyers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-02T16:49:33Z

@ianrichr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary

Reviewed-by: shade, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

cde8aca: 8069389: CompilerOracle prefix wildcarding is broken for long strings
c1c8064: 8320005: Allow loading of shared objects with .a extension on AIX
d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately
1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
a4b40e8: 8291226: Create Test Cases to cover scenarios for JDK-8278067
af033c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test
5968b15: 8328809: [8u] Problem list some CA tests
e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
5256587: Merge
... and 12 more: https://git.openjdk.org/jdk8u-dev/compare/04ccdbf84df493283a2755c996b3381500a79aa8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2024-04-02T16:59:20Z

Webrevs

00: Full (85e2a00e)

shipilev

This really looks like an omission in the 8u backport. The original change does add /test/lib: openjdk/jdk@e10da99?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28

openjdk · 2024-04-02T17:05:15Z

⚠️ @ianrichr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

ianrichr · 2024-04-03T10:10:46Z

/approval request Fixes the test compilation failure. The test passes after the fix. This fix is present in the original change, but seems to have been mistakenly omitted in the 8u backport. tier1 tests pass with unrelated CAInterop failures. Risk is low, test-only fix.

openjdk · 2024-04-03T10:11:37Z

@ianrichr
8329544: The approval request has been created successfully.

jerboaa · 2024-04-05T14:16:33Z

/approve yes

openjdk · 2024-04-05T14:17:20Z

@jerboaa
8329544: The approval request has been approved.

gnu-andrew · 2024-04-10T00:40:38Z

This really looks like an omission in the 8u backport. The original change does add /test/lib: openjdk/jdk@e10da99?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28

Probably because it wasn't necessary. If you read #418 it passes without this and indeed it didn't fail for me just now either. The only way I could get the error quoted was to remove external.lib.roots (openjdk/jdk8u@eace2d7#diff-6f996ccac16c4cddc35780b36cf8a2ea80780bb3486564a30f71dafa2af0fbe3R31)

I see no harm in adding it, but it's not that this went untested to begin with. It does work as is in some configurations.

Note that /test/lib is pretty new in 8u and was only created by JDK-8305329 last November, so it has been standard to remove/change this prior to that change.

gnu-andrew

Seems a harmless addition, but also not always necessary

ianrichr · 2024-04-12T12:14:38Z

/integrate

openjdk · 2024-04-12T12:15:16Z

@ianrichr
Your change (at version 85e2a00) is now ready to be sponsored by a Committer.

gnu-andrew · 2024-04-15T21:43:52Z

/sponsor

openjdk · 2024-04-15T21:44:53Z

Going to push as commit c6ba33e.
Since your change was applied there have been 22 commits pushed to the master branch:

cde8aca: 8069389: CompilerOracle prefix wildcarding is broken for long strings
c1c8064: 8320005: Allow loading of shared objects with .a extension on AIX
d0d9a15: 8291638: Keep-Alive timeout of 0 should close connection immediately
1db6a76: 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
a4b40e8: 8291226: Create Test Cases to cover scenarios for JDK-8278067
af033c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
66fa62a: 8325927: [8u] Backport of JDK-8170552 missed part of the test
5968b15: 8328809: [8u] Problem list some CA tests
e72ea2d: 8317507: C2 compilation fails with "Exceeded _node_regs array"
5256587: Merge
... and 12 more: https://git.openjdk.org/jdk8u-dev/compare/04ccdbf84df493283a2755c996b3381500a79aa8...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-04-15T21:45:01Z

@gnu-andrew @ianrichr Pushed as commit c6ba33e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Add /test/lib path to @library in sun/security/krb5/auto/ReplayCacheT…

85e2a00

…estProc.java

openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024

ianrichr changed the title ~~8329544: sun/security/krb5/auto/ReplayCacheTestProc.java fails to compile due to incorrect classpath set by @library~~ [8u] sun/security/krb5/auto/ReplayCacheTestProc.java fails due to incorrect classpath set by @library Apr 2, 2024

openjdk bot removed the rfr Pull request is ready for review label Apr 2, 2024

ianrichr changed the title ~~[8u] sun/security/krb5/auto/ReplayCacheTestProc.java fails due to incorrect classpath set by @library~~ 8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java fails due to incorrect classpath set by @library Apr 2, 2024

ianrichr changed the title ~~8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java fails due to incorrect classpath set by @library~~ 8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary Apr 2, 2024

openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024

shipilev approved these changes Apr 2, 2024

View reviewed changes

ianrichr mentioned this pull request Apr 2, 2024

8168518: rcache interop with krb5-1.15 #418

Closed

4 tasks

openjdk bot added the approval label Apr 3, 2024

ianrichr mentioned this pull request Apr 4, 2024

Add /test/lib path to @library in sun/security/krb5/auto/ReplayCacheTestProc.java corretto/corretto-8#505

Merged

openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 5, 2024

gnu-andrew approved these changes Apr 10, 2024

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 12, 2024

openjdk bot added the integrated Pull request has been integrated label Apr 15, 2024

openjdk bot closed this Apr 15, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary #478

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary #478

ianrichr commented Apr 2, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 2, 2024

openjdk bot commented Apr 2, 2024 •

edited

Loading

mlbridge bot commented Apr 2, 2024

shipilev left a comment

openjdk bot commented Apr 2, 2024

ianrichr commented Apr 3, 2024

openjdk bot commented Apr 3, 2024

jerboaa commented Apr 5, 2024

openjdk bot commented Apr 5, 2024

gnu-andrew commented Apr 10, 2024

gnu-andrew left a comment

ianrichr commented Apr 12, 2024

openjdk bot commented Apr 12, 2024

gnu-andrew commented Apr 15, 2024

openjdk bot commented Apr 15, 2024

openjdk bot commented Apr 15, 2024

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary #478

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary #478

Conversation

ianrichr commented Apr 2, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 2, 2024

openjdk bot commented Apr 2, 2024 • edited Loading

mlbridge bot commented Apr 2, 2024

Webrevs

shipilev left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 2, 2024

ianrichr commented Apr 3, 2024

openjdk bot commented Apr 3, 2024

jerboaa commented Apr 5, 2024

openjdk bot commented Apr 5, 2024

gnu-andrew commented Apr 10, 2024

gnu-andrew left a comment

Choose a reason for hiding this comment

ianrichr commented Apr 12, 2024

openjdk bot commented Apr 12, 2024

gnu-andrew commented Apr 15, 2024

openjdk bot commented Apr 15, 2024

openjdk bot commented Apr 15, 2024

ianrichr commented Apr 2, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 2, 2024 •

edited

Loading