Skip to content

Conversation

@shruacha1234
Copy link

@shruacha1234 shruacha1234 commented Apr 15, 2024

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
Backporting openjdk/jdk@1b92518


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8235834 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8235834: IBM-943 charset encoder needs updating (Bug - P3)

Contributors

  • Pratiksha Sawant <Pratiksha.Sawant@ibm.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/480/head:pull/480
$ git checkout pull/480

Update a local copy of the PR:
$ git checkout pull/480
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 480

View PR using the GUI difftool:
$ git pr show -t 480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/480.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2024

👋 Welcome back shruacha1234! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1b925183894778acce8aff4c101f67af98f0097f 8235834: IBM-943 charset encoder needs updating Apr 15, 2024
@openjdk
Copy link

openjdk bot commented Apr 15, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 15, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2024

Webrevs

@shruacha1234
Copy link
Author

/contributor add psawant19

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

@shruacha1234 psawant19 was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@shruacha1234
Copy link
Author

/contributor add Pratiksha Sawant Pratiksha.Sawant@ibm.com

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

@shruacha1234
Contributor Pratiksha Sawant <Pratiksha.Sawant@ibm.com> successfully added.

@shruacha1234
Copy link
Author

@naotoj Can you please review this PR

@shruacha1234
Copy link
Author

@naotoj Can you please take a look at this PR

@naotoj
Copy link
Member

naotoj commented Apr 19, 2024

@shruacha1234 Looks like the changeset includes more than the original fix. Also can you please ask someone else who maintains OpenJDK 8u for the 'R'eview? Thank you.

Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1@ibm.com>
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@shruacha1234
Copy link
Author

@gnu-andrew Can you please review this PR

Comment on lines +27 to +28
* @summary Check if the problems reported in above bugs have been fixed
* @modules jdk.charsets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are the issue. These are not part of head-stream patch. Please remove them and then this will be a clean patch.

@offamitkumar
Copy link
Member

openjdk/jdk@61c3a29#diff-d7cfb545c4f2d402274530dbce0bc6223deb998a131e3231e66a262e293cc550 this is the patch you need to backport for those extra two lines which you have added.

@shruacha1234
Copy link
Author

Duplicate of #476. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants