8235834: IBM-943 charset encoder needs updating#480
8235834: IBM-943 charset encoder needs updating#480shruacha1234 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shruacha1234! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue and summary from the original commit. |
Webrevs
|
|
/contributor add psawant19 |
|
@shruacha1234 Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
|
/contributor add Pratiksha Sawant Pratiksha.Sawant@ibm.com |
|
@shruacha1234 |
|
@naotoj Can you please review this PR |
|
@naotoj Can you please take a look at this PR |
|
@shruacha1234 Looks like the changeset includes more than the original fix. Also can you please ask someone else who maintains OpenJDK 8u for the 'R'eview? Thank you. |
Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1@ibm.com>
e5ab96a to
82990ff
Compare
|
@shruacha1234 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@gnu-andrew Can you please review this PR |
| * @summary Check if the problems reported in above bugs have been fixed | ||
| * @modules jdk.charsets |
There was a problem hiding this comment.
These two lines are the issue. These are not part of head-stream patch. Please remove them and then this will be a clean patch.
|
openjdk/jdk@61c3a29#diff-d7cfb545c4f2d402274530dbce0bc6223deb998a131e3231e66a262e293cc550 this is the patch you need to backport for those extra two lines which you have added. |
|
Duplicate of #476. Closing this PR |
Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
Backporting openjdk/jdk@1b92518
Progress
Issue
Contributors
<Pratiksha.Sawant@ibm.com>Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/480/head:pull/480$ git checkout pull/480Update a local copy of the PR:
$ git checkout pull/480$ git pull https://git.openjdk.org/jdk8u-dev.git pull/480/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 480View PR using the GUI difftool:
$ git pr show -t 480Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/480.diff
Webrev
Link to Webrev Comment