Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326529: JFR: Test for CompilerCompile events fails due to time out #484

Conversation

roberttoyonaga
Copy link
Contributor

@roberttoyonaga roberttoyonaga commented Apr 19, 2024

This is a backport of openjdk/jdk@4dd6c44

This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).

Testing: the updated jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326529 needs maintainer approval

Issue

  • JDK-8326529: JFR: Test for CompilerCompile events fails due to time out (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/484/head:pull/484
$ git checkout pull/484

Update a local copy of the PR:
$ git checkout pull/484
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 484

View PR using the GUI difftool:
$ git pr show -t 484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/484.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 19, 2024

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@roberttoyonaga This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326529: JFR: Test for CompilerCompile events fails due to time out

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures
  • 216b8cb: 8331791: [8u] AIX build break from JDK-8320005 backport
  • 853a87a: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • 89def4d: 8331980: [8u] Problem list CAInterop.java#certignarootca test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8 8326529: JFR: Test for CompilerCompile events fails due to time out Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 19, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@roberttoyonaga
Copy link
Contributor Author

/approval request for the backport of a JFR test case fix. Should be very low risk since it's only a small change to test case code.

The GHA failures do not seem to be related to this change, and are failing for the other PRs as well.
It the tests are failing with the following message:
PKIX path validation failed: java.security.cert.CertPathValidatorException: Certificate does not specify OCSP responder

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@roberttoyonaga
8326529: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 30, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2024

@roberttoyonaga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 28, 2024
@roberttoyonaga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@roberttoyonaga
Your change (at version 7e46237) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented May 29, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 29, 2024

Going to push as commit db860f0.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures
  • 216b8cb: 8331791: [8u] AIX build break from JDK-8320005 backport
  • 853a87a: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • 89def4d: 8331980: [8u] Problem list CAInterop.java#certignarootca test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 29, 2024
@openjdk openjdk bot closed this May 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@jerboaa @roberttoyonaga Pushed as commit db860f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

/sponsor

This was pushed while 8u-dev was closed for rampdown [0]. Please don't do this.

I'll manually move this to 8u432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants