-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326529: JFR: Test for CompilerCompile events fails due to time out #484
8326529: JFR: Test for CompilerCompile events fails due to time out #484
Conversation
👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into |
@roberttoyonaga This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/approval request for the backport of a JFR test case fix. Should be very low risk since it's only a small change to test case code. The GHA failures do not seem to be related to this change, and are failing for the other PRs as well. |
@roberttoyonaga |
@roberttoyonaga This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/integrate |
@roberttoyonaga |
/sponsor |
Going to push as commit db860f0.
Your commit was automatically rebased without conflicts. |
@jerboaa @roberttoyonaga Pushed as commit db860f0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This was pushed while 8u-dev was closed for rampdown [0]. Please don't do this. I'll manually move this to 8u432. |
This is a backport of openjdk/jdk@4dd6c44
This backport limits compilation only to the test methods TestCompileCompile cares about. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3046).
Testing: the updated
jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java
test passes.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/484/head:pull/484
$ git checkout pull/484
Update a local copy of the PR:
$ git checkout pull/484
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/484/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 484
View PR using the GUI difftool:
$ git pr show -t 484
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/484.diff
Webrev
Link to Webrev Comment