Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jia-wei-tang
Copy link

@jia-wei-tang jia-wei-tang commented Apr 23, 2024

Hi all,

This pull request contains a backport of commit a4a5c7fe from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Grönlund.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8276125 needs maintainer approval

Issue

  • JDK-8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/485/head:pull/485
$ git checkout pull/485

Update a local copy of the PR:
$ git checkout pull/485
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 485

View PR using the GUI difftool:
$ git pr show -t 485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/485.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 23, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, the ci tests failure always get outputs like "E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages". What should I do? I think it is not a problem related to my backport.

@jia-wei-tang
Copy link
Author

/clean

@openjdk
Copy link

openjdk bot commented May 31, 2024

@jia-wei-tang Only OpenJDK Committers can use the /clean command

@jia-wei-tang
Copy link
Author

/approval request this backport of commit a4a5c7fe from the openjdk/jdk11u-dev repository.
The JVM crashes when using JFR. It's a clean backport.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@jia-wei-tang
8276125: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 26, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

@mgronlun Hi, could you approve this request ? It's a clean backport and related tests are all passed.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, how could I get this request reviewed?

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, anyone can help me with the approval and review it?

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean backport from 11u.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants