-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id #486
base: master
Are you sure you want to change the base?
8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id #486
Conversation
👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/clean Only file location differs. |
@phohensee This backport pull request is now marked as clean |
|
Many GHA infra issues, plus what seem to be unrelated test failures. |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, the ci tests failure seems to be unrelated to my backport. Can anyone help me? Some outputs of those failure: |
If all the failures are infra issues, then just go ahead and request maintainer approval. |
@phohensee Could you pls approve this JDK-8322511 and review the codes? It's a clean backport. |
I'm not a maintainer, so can't approve backports. Review, yes, approve, no. Please use the "/approval request <text describing reason for backport, testing, and risk>" PR comment to request approval by a maintainer. |
/approval request this backport of commit 29f300eb from the openjdk/jdk11u-dev repository. |
@jia-wei-tang |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, how could I get the approval ? |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, anyone can help me with this approval? |
Hi all,
This pull request contains a backport of commit 29f300eb from the openjdk/jdk11u-dev repository.
The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/486/head:pull/486
$ git checkout pull/486
Update a local copy of the PR:
$ git checkout pull/486
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/486/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 486
View PR using the GUI difftool:
$ git pr show -t 486
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/486.diff
Webrev
Link to Webrev Comment