Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id #486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jia-wei-tang
Copy link

@jia-wei-tang jia-wei-tang commented Apr 23, 2024

Hi all,

This pull request contains a backport of commit 29f300eb from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.

Thanks!


Progress

  • JDK-8322511 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/486/head:pull/486
$ git checkout pull/486

Update a local copy of the PR:
$ git checkout pull/486
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 486

View PR using the GUI difftool:
$ git pr show -t 486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/486.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 29f300eb2ac4c038fad7f8e09eab8a53b69526c6 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 23, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2024

Webrevs

@phohensee
Copy link
Member

/clean

Only file location differs.

@openjdk openjdk bot added the clean label Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

⚠️ @jia-wei-tang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@phohensee
Copy link
Member

Many GHA infra issues, plus what seem to be unrelated test failures.

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, the ci tests failure seems to be unrelated to my backport. Can anyone help me?

Some outputs of those failure:
E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages (Linux additional (hs s390x build only))
Error: Unable to find any artifacts for the associated workflow (Linux x64 (jdk/tier1))

@phohensee
Copy link
Member

If all the failures are infra issues, then just go ahead and request maintainer approval.

@jia-wei-tang
Copy link
Author

@phohensee Could you pls approve this JDK-8322511 and review the codes? It's a clean backport.

@phohensee
Copy link
Member

phohensee commented Jun 19, 2024

I'm not a maintainer, so can't approve backports. Review, yes, approve, no.

Please use the "/approval request <text describing reason for backport, testing, and risk>" PR comment to request approval by a maintainer.

@jia-wei-tang
Copy link
Author

/approval request this backport of commit 29f300eb from the openjdk/jdk11u-dev repository.
The JVM crashes when using JFR. It's a clean backport.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@jia-wei-tang
8322511: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 26, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

@mgronlun Hi, could you approve this request? The JVM crashes when using JFR. It's a clean backport.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, how could I get the approval ?

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jia-wei-tang
Copy link
Author

Hi, anyone can help me with this approval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants