8330973: Test8009761 fails on ppcle_linux: init recursive calls: 38. After deopt 37 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775. This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix. Signed-off-by: Adam Farley <adfarley@redhat.com>
|
👋 Welcome back afarley! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
I think we should try backporting the test-only fix itself: JDK-8021775 |
adamfarley
changed the title
I don't mind. Will see if that fix merges cleanly with the current version of the JDK8 test. |
|
Closing this as it's cleaner to have the automated system open a new PR with the backported change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775.
This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix.
https://bugs.openjdk.org/browse/JDK-8330973
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/487/head:pull/487$ git checkout pull/487Update a local copy of the PR:
$ git checkout pull/487$ git pull https://git.openjdk.org/jdk8u-dev.git pull/487/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 487View PR using the GUI difftool:
$ git pr show -t 487Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/487.diff
Webrev
Link to Webrev Comment