Skip to content

Conversation

@yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Apr 28, 2024

This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.

This patch has already been applied to OracleJDK8.

This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8222299 needs maintainer approval

Issue

  • JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/containers (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488
$ git checkout pull/488

Update a local copy of the PR:
$ git checkout pull/488
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 488

View PR using the GUI difftool:
$ git pr show -t 488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/488.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 66c817134fa012d53128eecfc1bac0c32c678145 8222299: [TESTBUG] move hotspot container tests to hotspot/containers Apr 28, 2024
@openjdk
Copy link

openjdk bot commented Apr 28, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 28, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2024

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2024

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 19, 2024
@yaqsun
Copy link
Contributor Author

yaqsun commented Nov 1, 2024

/open

@openjdk openjdk bot reopened this Nov 1, 2024
@openjdk
Copy link

openjdk bot commented Nov 1, 2024

@yaqsun This pull request is now open

@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2024

@yaqsun This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2024

@yaqsun This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant