Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285445: cannot open file "NUL:" #49

Closed
wants to merge 1 commit into from
Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Apr 28, 2022

Hi all,
This pull request contains a backport of commit 03cbb48e from the openjdk/jdk repository.
The commit being backported was authored by Brian Burkhalter on 23 Apr 2022 and was reviewed by Mikael Vidstedt.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/49.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 28, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03cbb48e6a1d806f204a39bbdbb4bc9be9e57a41 8285445: cannot open file "NUL:" Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 28, 2022
@mrserb
Copy link
Member Author

mrserb commented Apr 28, 2022

/clean Only the paths are changed

@openjdk openjdk bot added the clean label Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285445: cannot open file "NUL:"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2022
@mrserb mrserb marked this pull request as ready for review April 28, 2022 22:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 28, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 28, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 607b14e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@mrserb Pushed as commit 607b14e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8285445 branch April 29, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant