6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I would like to backport this patch to improve test maintainability.
Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
Given this, the @debuggeeVMOptions mechanism can be safely removed.
The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.
There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493
Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.
Testing: All tests under jdk/test/com/sun/jdi
Thank you.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/492/head:pull/492
$ git checkout pull/492
Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/492/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 492
View PR using the GUI difftool:
$ git pr show -t 492
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/492.diff
Webrev
Link to Webrev Comment