Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented May 7, 2024

Hi all,

I would like to backport this patch to improve test maintainability.
Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
Given this, the @debuggeeVMOptions mechanism can be safely removed.
The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.

There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493
Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-6622468 needs maintainer approval

Issue

  • JDK-6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/492/head:pull/492
$ git checkout pull/492

Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 492

View PR using the GUI difftool:
$ git pr show -t 492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/492.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9158c1d9b686179742f4b129a9aee02c95458a58 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 7, 2024
@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant