8331791: [8u] AIX build break from JDK-8320005 backport #494

suchismith1993 · 2024-05-08T07:44:07Z

c1c8064
introduces a new call to the macro FREE_C_HEAP_ARRAY
but is not using the correct number of arguments.
jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
JBS-ISSUE: JDK-8331791

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8331791 needs maintainer approval

Issue

JDK-8331791: [8u] AIX build break from JDK-8320005 backport (Bug - P1 - Approved)

Reviewers

Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/494/head:pull/494
$ git checkout pull/494

Update a local copy of the PR:
$ git checkout pull/494
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 494

View PR using the GUI difftool:
$ git pr show -t 494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/494.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-05-08T07:44:39Z

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-05-08T07:44:54Z

@suchismith1993 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8331791: [8u] AIX build break from JDK-8320005 backport

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2024-05-08T07:48:06Z

Webrevs

jerboaa

@suchismith1993 I take it you've verified that it builds correctly on AIX?

openjdk · 2024-05-08T08:28:23Z

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

suchismith1993 · 2024-05-08T08:53:24Z

@jerboaa Need some time, as last time i understood that the pre submit tests are enough. And don't want to repeat any test failures.
I am getting a build error, but not sure if it has to do with same file. Is there some way i can get better log outputs ?

Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/output.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/park.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse1.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse2.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse3.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parseHelper.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/prims/wbtestmethods/parserTests.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/code/pcDesc.cpp
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1486.18: 1540-2935 (S) A C++0x feature is being used. Use the extended0x langlvl or langlvl "Nullptr" to enable this feature.
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1486.18: 1540-2955 (I) Compilation may require C++0x Feature. Try using the option "-qlanglvl=nullptr".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1749.52: 1540-0216 (W) An expression of type "void " cannot be converted to type "extern "C" void ()(int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3548.35: 1540-0216 (W) An expression of type "void " cannot be converted to type "void ()()".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3551.35: 1540-0216 (W) An expression of type "void " cannot be converted to type "void ()()".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3553.34: 1540-0216 (W) An expression of type "void *" cannot be converted to type "sigaction ()(int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
gmake[6]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/makefiles/rules.make:151: os_aix.o] Error 1
gmake[6]: *** Waiting for unfinished jobs....
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "void ()(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "int ()(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char " cannot be converted to type "long ()(long *, long)".
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into CardTableModRefBS::byte_for(const void *) const.
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into WB_ParseCommandLine.
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into WB_ParseCommandLine.
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Klass::decode_klass_not_null(narrowKlass).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into objArrayHandle::objArrayHandle(Thread *, objArrayOop).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into oopDesc::decode_heap_oop_not_null(narrowOop).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Klass::decode_klass_not_null(narrowKlass).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParScanThreadState::take_from_overflow_stack().
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ScanClosureWithParBarrier::do_oop_work(unsigned int *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into oopDesc::size_given_klass(Klass *).
1501-201: (W) Maximum number of common component diagnostics, 10 has been exceeded.
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Compile::fill_buffer(CodeBuffer *, uint *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into CodeSection::set_end(address).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Compile::fill_buffer(CodeBuffer *, uint *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::BytecodeParseHistogram::print(float).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::dump().
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::dump().
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_one_block().
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::native_byte_order(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::uses_cp_cache(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::uses_cp_cache(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::adjust_map_after_if(BoolTest::mask, Node *, float, Block *, Block *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::adjust_map_after_if(BoolTest::mask, Node *, float, Block *, Block *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_ifnull(BoolTest::mask, Node *).
1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_ifnull(BoolTest::mask, Node *).
1501-201: (W) Maximum number of common component diagnostics, 10 has been exceeded.
gmake[5]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/makefiles/top.make:120: the_vm] Error 2
gmake[4]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/Makefile:297: fastdebug] Error 2
gmake[3]: *** [Makefile:231: generic_build2] Error 2
gmake[2]: *** [Makefile:177: fastdebug] Error 2
gmake[1]: *** [HotspotWrapper.gmk:45: /home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/hotspot/_hotspot.timestamp] Error 2
make: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev//make/Main.gmk:110: hotspot-only] Error 2

jerboaa · 2024-05-08T09:42:15Z

@jerboaa i understood that the pre submit tests are enough.

GHA only runs builds on Linux, Windows, Mac. AIX (especially on ppc) is not being run. It relies on you to verify that. Perhaps @sxa or @andrew-m-leonard can help you with testing a build on temurin's infra.

suchismith1993 · 2024-05-08T12:02:52Z

hotspot@p8-java1-hs02:[~/openjdk/suchijdk17/jdk8u-dev] make images
(cd /home/hotspot/openjdk/suchijdk17/jdk8u-dev/make && /opt/freeware/bin/gmake -s VERBOSE="-s" LOG_LEVEL="warn" -R -I /home/hotspot/openjdk/suchijdk17/jdk8u-dev/make/common "SPEC=/home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/spec.gmk" -j14 -f SourceRevision.gmk create-source-revision-tracker)
Building OpenJDK for target 'images' in configuration 'aix-ppc64-normal-server-fastdebug'

Starting langtools

Finished langtools (build time 00:00:00)

Starting hotspot

gmake[2]: warning: -j1 forced in submake: resetting jobserver mode.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
Rescanned ../generated/adfiles/aix_ppc_64.ad but encountered no changes.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
Linking vm...
ld: 0711-224 WARNING: Duplicate symbol: Hyp_Name
ld: 0711-224 WARNING: Duplicate symbol: __cdtors
ld: 0711-344 See the loadmap file libjvm.loadmap for more information.
All done.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0

Finished hotspot (build time 00:00:45)

Starting corba

Finished corba (build time 00:00:00)

Starting jaxp

Finished jaxp (build time 00:00:00)

Starting jaxws

Finished jaxws (build time 00:00:01)

Starting jdk

find: bad status-- /home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/hotspot/dist/lib

Finished jdk (build time 00:00:24)

Starting demos

Finished demos (build time 00:00:01)

Starting nashorn

Finished nashorn (build time 00:00:00)

Starting images

Finished images (build time 00:00:49)

----- Build times -------
Start 2024-05-08 11:47:10
End 2024-05-08 11:49:12
00:00:00 corba
00:00:01 demos
00:00:45 hotspot
00:00:49 images
00:00:00 jaxp
00:00:01 jaxws
00:00:24 jdk
00:00:00 langtools
00:00:00 nashorn
00:02:02 TOTAL

Finished building OpenJDK for target 'images'

suchismith1993 · 2024-05-08T12:03:19Z

@jerboaa no build failures with current changes. Can you take a look at the current changes.

jerboaa

Looks fine.

suchismith1993 · 2024-05-08T17:55:26Z

/approval request This back port is required to handle dynamic libraries of AIX.

openjdk · 2024-05-08T17:56:06Z

@suchismith1993
8331791: The approval request has been created successfully.

jerboaa · 2024-05-14T18:06:58Z

@suchismith1993 Please merge master and integrate this change. Thanks!

openjdk · 2024-05-15T08:58:04Z

@suchismith1993 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

suchismith1993 · 2024-05-15T08:58:56Z

/integrate

openjdk · 2024-05-15T08:59:48Z

@suchismith1993
Your change (at version 51d4ab4) is now ready to be sponsored by a Committer.

jerboaa · 2024-05-15T09:05:21Z

/sponsor

openjdk · 2024-05-15T09:06:27Z

Going to push as commit 216b8cb.

openjdk · 2024-05-15T09:06:37Z

@jerboaa @suchismith1993 Pushed as commit 216b8cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label May 8, 2024

jerboaa approved these changes May 8, 2024

View reviewed changes

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 8, 2024

suchismith1993 added 3 commits May 15, 2024 14:26

Correct number of parameters for FREE_C_HEAP_ARRAY

2e17d80

Change NULL value

493ecef

space

51d4ab4

suchismith1993 force-pushed the OsAixFixArguments branch from 40438ec to 51d4ab4 Compare May 15, 2024 08:57

openjdk bot added the sponsor Pull request is ready to be sponsored label May 15, 2024

openjdk bot added the integrated Pull request has been integrated label May 15, 2024

openjdk bot closed this May 15, 2024

openjdk bot removed the ready Pull request is ready to be integrated label May 15, 2024

openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8331791: [8u] AIX build break from JDK-8320005 backport #494

8331791: [8u] AIX build break from JDK-8320005 backport #494

suchismith1993 commented May 8, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 8, 2024

openjdk bot commented May 8, 2024 •

edited

Loading

mlbridge bot commented May 8, 2024 •

edited

Loading

jerboaa left a comment

openjdk bot commented May 8, 2024

suchismith1993 commented May 8, 2024

jerboaa commented May 8, 2024

suchismith1993 commented May 8, 2024

suchismith1993 commented May 8, 2024

jerboaa left a comment

suchismith1993 commented May 8, 2024

openjdk bot commented May 8, 2024

jerboaa commented May 14, 2024

openjdk bot commented May 15, 2024

suchismith1993 commented May 15, 2024

openjdk bot commented May 15, 2024

jerboaa commented May 15, 2024

openjdk bot commented May 15, 2024

openjdk bot commented May 15, 2024

8331791: [8u] AIX build break from JDK-8320005 backport #494

8331791: [8u] AIX build break from JDK-8320005 backport #494

Conversation

suchismith1993 commented May 8, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 8, 2024

openjdk bot commented May 8, 2024 • edited Loading

mlbridge bot commented May 8, 2024 • edited Loading

Webrevs

jerboaa left a comment

Choose a reason for hiding this comment

openjdk bot commented May 8, 2024

suchismith1993 commented May 8, 2024

jerboaa commented May 8, 2024

suchismith1993 commented May 8, 2024

Starting langtools

Finished langtools (build time 00:00:00)

Starting hotspot

Finished hotspot (build time 00:00:45)

Starting corba

Finished corba (build time 00:00:00)

Starting jaxp

Finished jaxp (build time 00:00:00)

Starting jaxws

Finished jaxws (build time 00:00:01)

Starting jdk

Finished jdk (build time 00:00:24)

Starting demos

Finished demos (build time 00:00:01)

Starting nashorn

Finished nashorn (build time 00:00:00)

Starting images

Finished images (build time 00:00:49)

----- Build times ------- Start 2024-05-08 11:47:10 End 2024-05-08 11:49:12 00:00:00 corba 00:00:01 demos 00:00:45 hotspot 00:00:49 images 00:00:00 jaxp 00:00:01 jaxws 00:00:24 jdk 00:00:00 langtools 00:00:00 nashorn 00:02:02 TOTAL

suchismith1993 commented May 8, 2024

jerboaa left a comment

Choose a reason for hiding this comment

suchismith1993 commented May 8, 2024

openjdk bot commented May 8, 2024

jerboaa commented May 14, 2024

openjdk bot commented May 15, 2024

suchismith1993 commented May 15, 2024

openjdk bot commented May 15, 2024

jerboaa commented May 15, 2024

openjdk bot commented May 15, 2024

openjdk bot commented May 15, 2024

suchismith1993 commented May 8, 2024 •

edited by openjdk bot

Loading

openjdk bot commented May 8, 2024 •

edited

Loading

mlbridge bot commented May 8, 2024 •

edited

Loading

----- Build times -------
Start 2024-05-08 11:47:10
End 2024-05-08 11:49:12
00:00:00 corba
00:00:01 demos
00:00:45 hotspot
00:00:49 images
00:00:00 jaxp
00:00:01 jaxws
00:00:24 jdk
00:00:00 langtools
00:00:00 nashorn
00:02:02 TOTAL