4660158: TTY: NumberFormatException while trying to set values by 'set' command

[ktakakuri]

Hi all,

JDK8 reproduces the reported bug and I would like to backport this patch. The patch is clean.
There is a related patch JDK-8030204, and I have proposed a separate backport for it. #497

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-4660158 needs maintainer approval

Issue

• JDK-4660158: TTY: NumberFormatException while trying to set values by 'set' command (Bug - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/496/head:pull/496
$ git checkout pull/496

Update a local copy of the PR:
$ git checkout pull/496
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 496

View PR using the GUI difftool:
$ git pr show -t 496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/496.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

4660158: TTY: NumberFormatException while trying to set values by 'set' command

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
• 61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• 8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
• 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
• db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
• 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
• ab408de: 8235834: IBM-943 charset encoder needs updating
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/6b53212ef78ad50f9eede829c5ff87cadcdb434b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (bf784b2f)

[ktakakuri]

TheGHA build failures for s390x and ppc64le, as well as the test failures for security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java are unrelated.
Test failures for com/sun/jdi/JdbExprTest.sh are resolved by the related backport.

[ktakakuri]

/approval request Fix Request 8u
I would like to backport this patch as this bug is reproducible in JDK8. The backport is clean and low risk. Backporting this requires the follow-up patch JDK-8030204 and the corresponding backport has been submitted.
Testing: GHA and All tests under jdk/test/com/sun/jdi.

[openjdk]

@ktakakuri
4660158: The approval request has been created successfully.

[gnu-andrew]

The backport is not completely clean, though Skara claims it is. A fragment from jdk/src/share/classes/com/sun/tools/example/debug/expr/TokenMgrError.java was dropped due to the copyright header already being changed by JDK-8029235, a private bug which did a blanket copyright update on a number of files.

Changes look fine though and I'm happy if the tests are passing on the updated version.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
4660158: The approval request has been approved.

[ktakakuri]

/integrate

[openjdk]

@ktakakuri
Your change (at version bf784b2) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit bfb1a7d.
Since your change was applied there have been 14 commits pushed to the master branch:

• 0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
• 61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• 8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
• 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
• db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 012f59c: 8316138: Add GlobalSign 2 TLS root certificates
• 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
• ab408de: 8235834: IBM-943 charset encoder needs updating
• ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/6b53212ef78ad50f9eede829c5ff87cadcdb434b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @ktakakuri Pushed as commit bfb1a7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.