-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\\'t convert 2147483648 to int" not found #497
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @zzambers) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
TheGHA build failures for s390x and ppc64le, as well as the test failures for security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java and gc/logging/TestGCId.java are unrelated. |
/approval request Backporting JDK-4660158 requires this follow-up patch. Applies cleanly. Low risk, test fix. Tesing: GHA and the affected test. |
@ktakakuri |
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8030204
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
I resolved the conflicts. |
/integrate |
@ktakakuri This pull request has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed clean.
/approve yes |
@gnu-andrew |
/integrate |
@ktakakuri |
/sponsor |
Going to push as commit b499ea7.
Your commit was automatically rebased without conflicts. |
@zzambers @ktakakuri Pushed as commit b499ea7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This test fix patch is required for Backporting JDK-4660158 and should be backported at the same time. #496
The patch can be applied cleanly to JDK-4660158 applied code.
Testing: All tests under jdk/test/com/sun/jdi
Thank you.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/497/head:pull/497
$ git checkout pull/497
Update a local copy of the PR:
$ git checkout pull/497
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/497/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 497
View PR using the GUI difftool:
$ git pr show -t 497
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/497.diff
Webrev
Link to Webrev Comment