Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\\'t convert 2147483648 to int" not found #497

Closed
wants to merge 3 commits into from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented May 13, 2024

Hi all,

This test fix patch is required for Backporting JDK-4660158 and should be backported at the same time. #496
The patch can be applied cleanly to JDK-4660158 applied code.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8030204 needs maintainer approval

Issue

  • JDK-8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/497/head:pull/497
$ git checkout pull/497

Update a local copy of the PR:
$ git checkout pull/497
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 497

View PR using the GUI difftool:
$ git pr show -t 497

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/497.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into pr/496 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\\'t convert 2147483648 to int" not found

Reviewed-by: andrew, zzambers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b1e2ea8: 8279164: Disable TLS_ECDH_* cipher suites
  • 6abb3f2: 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use
  • 6838605: 8311666: Disabled tests in test/jdk/sun/java2d/marlin

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew, @zzambers) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4799040e87ad97963e8d089d4338d429b1f7b0d1 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\\'t convert 2147483648 to int" not found May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@ktakakuri
Copy link
Contributor Author

TheGHA build failures for s390x and ppc64le, as well as the test failures for security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java and gc/logging/TestGCId.java are unrelated.

@ktakakuri
Copy link
Contributor Author

/approval request Backporting JDK-4660158 requires this follow-up patch. Applies cleanly. Low risk, test fix. Tesing: GHA and the affected test.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@ktakakuri
8030204: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 20, 2024
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/496 to master June 13, 2024 23:38
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8030204
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Jun 13, 2024
@openjdk openjdk bot added the clean label Jun 14, 2024
@ktakakuri
Copy link
Contributor Author

I resolved the conflicts.
I adopted HEAD for all conflicts.

@ktakakuri
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@ktakakuri This pull request has not yet been marked as ready for integration.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Jun 15, 2024

@gnu-andrew
8030204: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 15, 2024
@ktakakuri
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 16, 2024
@openjdk
Copy link

openjdk bot commented Jun 16, 2024

@ktakakuri
Your change (at version 8541835) is now ready to be sponsored by a Committer.

@zzambers
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit b499ea7.
Since your change was applied there have been 3 commits pushed to the master branch:

  • b1e2ea8: 8279164: Disable TLS_ECDH_* cipher suites
  • 6abb3f2: 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use
  • 6838605: 8311666: Disabled tests in test/jdk/sun/java2d/marlin

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@zzambers @ktakakuri Pushed as commit b499ea7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants