-
Notifications
You must be signed in to change notification settings - Fork 159
8316138: Add GlobalSign 2 TLS root certificates #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into |
@zzambers This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I agree the failing cases are not related to this backport.
Please flag for approval with /approval request
.
|
/approval request Adds 2 CA certificates, tests OK |
/approve yes |
@gnu-andrew |
@gnu-andrew thanks /integrate |
Going to push as commit 012f59c.
Your commit was automatically rebased without conflicts. |
Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with
-Dcom.sun.security.ocsp.useget=false
parameter were removed inCAInterop.java
, as property was introduced by JDK-8328638 and is only JDK17+.Testing:
Tests look OK. There are these 3 failures in CAInterop.java:
these are not caused by this backport, I can see same 3 failures on master (probably appeared recently).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/502/head:pull/502
$ git checkout pull/502
Update a local copy of the PR:
$ git checkout pull/502
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/502/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 502
View PR using the GUI difftool:
$ git pr show -t 502
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/502.diff
Webrev
Link to Webrev Comment