Skip to content

8316138: Add GlobalSign 2 TLS root certificates #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 20, 2024

Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with -Dcom.sun.security.ocsp.useget=false parameter were removed in CAInterop.java, as property was introduced by JDK-8328638 and is only JDK17+.

Testing:
Tests look OK. There are these 3 failures in CAInterop.java:

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 

these are not caused by this backport, I can see same 3 failures on master (probably appeared recently).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8316138 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316138: Add GlobalSign 2 TLS root certificates (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/502/head:pull/502
$ git checkout pull/502

Update a local copy of the PR:
$ git checkout pull/502
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 502

View PR using the GUI difftool:
$ git pr show -t 502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/502.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 20, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316138: Add GlobalSign 2 TLS root certificates

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 8316138: Add GlobalSign 2 TLS root certificates May 20, 2024
@openjdk
Copy link

openjdk bot commented May 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 20, 2024
@mlbridge
Copy link

mlbridge bot commented May 20, 2024

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I agree the failing cases are not related to this backport.
Please flag for approval with /approval request.

@openjdk
Copy link

openjdk bot commented May 21, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Adds 2 CA certificates, tests OK

@openjdk
Copy link

openjdk bot commented May 21, 2024

@zzambers
8316138: The approval request has been created successfully.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented May 22, 2024

@gnu-andrew
8316138: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 22, 2024
@zzambers
Copy link
Contributor Author

@gnu-andrew thanks

/integrate

@openjdk
Copy link

openjdk bot commented May 22, 2024

Going to push as commit 012f59c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 7bcaeb5: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  • ab408de: 8235834: IBM-943 charset encoder needs updating
  • b3308b1: 8328825: Google CAInterop test failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 22, 2024
@openjdk openjdk bot closed this May 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 22, 2024
@openjdk
Copy link

openjdk bot commented May 22, 2024

@zzambers Pushed as commit 012f59c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants