Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328825: Google CAInterop test failures #503

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 21, 2024

Backport fixes Google cert failures in CAInterop test. Only updates test. Changeset applied cleanly (with fixed file path). It additionally removes appropriate entries from ProblemList.txt (these are JDK8 only).

Testing:
Relevant tests pass testing. (other ones are not regressions to master, see also: #502)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328825 needs maintainer approval

Issue

  • JDK-8328825: Google CAInterop test failures (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/503/head:pull/503
$ git checkout pull/503

Update a local copy of the PR:
$ git checkout pull/503
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 503

View PR using the GUI difftool:
$ git pr show -t 503

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/503.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 21, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8328825: Google CAInterop test failures

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624 8328825: Google CAInterop test failures May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 21, 2024
@mlbridge
Copy link

mlbridge bot commented May 21, 2024

Webrevs

@zzambers
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

@zzambers This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 21, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Backport fixing Google cert failures in CAInterop test. Only updates test. Clean. (except for different paths on 8u + ProblemList)

@openjdk
Copy link

openjdk bot commented May 21, 2024

@zzambers
8328825: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 21, 2024
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jerboaa
Copy link
Contributor

jerboaa commented May 21, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented May 21, 2024

@jerboaa
8328825: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 21, 2024
@zzambers
Copy link
Contributor Author

@jerboaa thanks

/integrate

@openjdk
Copy link

openjdk bot commented May 21, 2024

Going to push as commit b3308b1.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 21, 2024
@openjdk openjdk bot closed this May 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2024
@openjdk
Copy link

openjdk bot commented May 21, 2024

@zzambers Pushed as commit b3308b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants