Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes #505

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 24, 2024

Hi all,
This is clean backport of JDK-8316328, which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316328 needs maintainer approval

Issue

  • JDK-8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/505/head:pull/505
$ git checkout pull/505

Update a local copy of the PR:
$ git checkout pull/505
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 505

View PR using the GUI difftool:
$ git pr show -t 505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/505.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 24, 2024
@mlbridge
Copy link

mlbridge bot commented May 24, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport , which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@sendaoYan
8316328: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 24, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented May 24, 2024

The GHA test runner report two failures on Create sysroot stage, it may be an environmental issue, unrelated to this PR.

@sendaoYan
Copy link
Member Author

Duplicated. Sorry for that.

@sendaoYan sendaoYan closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant