Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes #506

Closed
wants to merge 2 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 24, 2024

Hi all,

This pull request contains a backport of commit 9b1d6d66 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316328 needs maintainer approval

Issue

  • JDK-8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/506/head:pull/506
$ git checkout pull/506

Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 506

View PR using the GUI difftool:
$ git pr show -t 506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/506.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 7c13bd8: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
  • 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad: 8318951: Additional negative value check in JPEG decoding

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review May 24, 2024 04:28
@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2024
@mlbridge
Copy link

mlbridge bot commented May 24, 2024

Webrevs

@phohensee
Copy link
Member

GHA failures appear unrelated.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Jun 27, 2024

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Aug 12, 2024

keep open

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a trivial clean backport to me.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Aug 30, 2024

@gnu-andrew
8316328: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 30, 2024
@mrserb
Copy link
Member Author

mrserb commented Aug 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2024

Going to push as commit 8b0fedc.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 7c13bd8: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
  • 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad: 8318951: Additional negative value check in JPEG decoding

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2024
@openjdk openjdk bot closed this Aug 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2024
@openjdk
Copy link

openjdk bot commented Aug 30, 2024

@mrserb Pushed as commit 8b0fedc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants