Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311666: Disabled tests in test/jdk/sun/java2d/marlin #507

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 24, 2024

Hi all,

This pull request contains a backport of commit b285ed72 from the openjdk/jdk repository.

The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8311666 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311666: Disabled tests in test/jdk/sun/java2d/marlin (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/507/head:pull/507
$ git checkout pull/507

Update a local copy of the PR:
$ git checkout pull/507
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 507

View PR using the GUI difftool:
$ git pr show -t 507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/507.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8311666: Disabled tests in test/jdk/sun/java2d/marlin

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • bfb1a7d: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
  • 0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • 61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • 8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
  • 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
  • 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
  • db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b285ed72aebe2d802fa9c071372cea6c09870b9a 8311666: Disabled tests in test/jdk/sun/java2d/marlin May 24, 2024
@openjdk
Copy link

openjdk bot commented May 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 24, 2024
@mrserb mrserb marked this pull request as ready for review May 29, 2024 00:19
@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2024
@mlbridge
Copy link

mlbridge bot commented May 29, 2024

Webrevs

@mrserb
Copy link
Member Author

mrserb commented May 29, 2024

/clean The patch is identical to the openjdk/jdk, paths are different.

@openjdk openjdk bot added the clean label May 29, 2024
@openjdk
Copy link

openjdk bot commented May 29, 2024

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented May 29, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label May 29, 2024
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean. Adds test metadata so tests are now run.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Jun 15, 2024

@gnu-andrew
8311666: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 15, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit 6838605.
Since your change was applied there have been 8 commits pushed to the master branch:

  • bfb1a7d: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
  • 0357abb: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • 61dde50: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
  • 8892b81: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
  • 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
  • 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link
  • 663ecc7: 8333126: Bump update version of OpenJDK: 8u432
  • db860f0: 8326529: JFR: Test for CompilerCompile events fails due to time out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@mrserb Pushed as commit 6838605.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants