Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8207011: Remove uses of the register storage class specifier #508

Closed
wants to merge 2 commits into from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented May 27, 2024

Make jdk8 natively buildable on a recent Linux system (tested Fedora 40 = gcc-14.1).
Cherry-pick was not clean but removing register is a simple task.
There will be 8 backports needed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8207011 needs maintainer approval

Issue

  • JDK-8207011: Remove uses of the register storage class specifier (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/508/head:pull/508
$ git checkout pull/508

Update a local copy of the PR:
$ git checkout pull/508
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 508

View PR using the GUI difftool:
$ git pr show -t 508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/508.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6ffd168ad145af0b6fdd72f3130e79b6a1bb9ad0 8207011: Remove uses of the register storage class specifier May 27, 2024
@openjdk
Copy link

openjdk bot commented May 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 27, 2024
@mlbridge
Copy link

mlbridge bot commented May 27, 2024

Webrevs

@jankratochvil
Copy link
Author

There should be -std=gnu++98 but for some reason some (all?) source files do not use it, to be investigated more.

@zzambers
Copy link
Contributor

There should be -std=gnu++98 but for some reason some (all?) source files do not use it, to be investigated more.

AFAIK this is work in progress by @gnu-andrew in: #357

@gnu-andrew
Copy link
Member

There should be -std=gnu++98 but for some reason some (all?) source files do not use it, to be investigated more.

AFAIK this is work in progress by @gnu-andrew in: #357

Thanks. Yes, that should solve this problem without having to adjust the source code and should now be ready for review. I'll see if I can get some people to give it a fresh look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants