8326521: JFR: CompilerPhase event test fails on windows 32 bit

[roberttoyonaga]

This is a backport of openjdk/jdk@96530bc

On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events .

This backport prevents NeverActAsServerClassMachine from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium specific to JDK8 (see adoptium/aqa-tests#3045).

Testing: running test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java test passes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8326521 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8326521: JFR: CompilerPhase event test fails on windows 32 bit (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/512/head:pull/512
$ git checkout pull/512

Update a local copy of the PR:
$ git checkout pull/512
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 512

View PR using the GUI difftool:
$ git pr show -t 512

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/512.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326521: JFR: CompilerPhase event test fails on windows 32 bit

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (51d5043f)

[openjdk]

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[roberttoyonaga]

The failing GHAs don't seem to be related to the changes in this PR:

• Linux additional (hs s390x build only) / Linux additional (hs ppc64le build only)

  • Fails in "Create sysroot" step with: Cannot check Release signature; keyring file not available /usr/share/keyrings/debian-archive-keyring.gpg. It seems like this is some sort of environment setup / infrastructure problem.

• Windows x86 (build debug) / Windows x86 (build release)

  • Fails in Download and unpack Visual Studio 2010 step with: Extracting archive: C:\Users\runneradmin\VS2010Express1.iso Can't open as archive: 1. It looks like the Visual Studio download is no longer good.

• macOS x64 (jdk/tier1) / Linux x64 (jdk/tier1) / Linux x86 (jdk/tier1) / Windows x64 (jdk/tier1)

  • Fails security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1 with: Test threw exception: java.lang.RuntimeException: Intermediate Root CA not found in the chain
  • I'm able to reproduce this locally on a clean master branch, so the failure seems independent of this PR. It looks like the URL used in the test (https://juolukka.cover.sonera.net:10443) needs to be updated, but I'm not sure what to change it to.

• Linux x86 (hotspot/tier1)

  • Fails gc/ergonomics/TestDynamicNumberOfGCThreads.java with: Agent 3 timed out with a timeout of 480 seconds; check console log for any additional details
  • This also doesn't seem related to the changes here since this PR does not touch any GC or thread related code, only JFR test code.

[roberttoyonaga]

/approval request for the backport of a JFR test fix for TestCompilerPhase. The backport is essentially clean, aside from a difference in the file path. Low risk, since only test code is changed. Some GHAs are failing, but they do not seem to be related to the changes here.

[openjdk]

@roberttoyonaga
8326521: The approval request has been created successfully.

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version 51d5043) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 8892b81.
Since your change was applied there have been 2 commits pushed to the master branch:

• 9da7380: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa79: 8333669: [8u] GHA: Dead VS2010 download link

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @roberttoyonaga Pushed as commit 8892b81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.