Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails #515

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 9, 2024

Hi all,

This pull request contains a backport of commit c640fe42 from the openjdk/jdk repository.

The commit being backported was authored by lawrence.andrews on 5 Sep 2021 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-7188098 needs maintainer approval

Issue

  • JDK-7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/515/head:pull/515
$ git checkout pull/515

Update a local copy of the PR:
$ git checkout pull/515
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 515

View PR using the GUI difftool:
$ git pr show -t 515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/515.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • d4adbe3: 8152207: Perform array bound checks while getting a length of bytecode instructions
  • 047b08a: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 32 more: https://git.openjdk.org/jdk8u-dev/compare/61dde50292198f9f35f906eef00b1fd002a19074...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c640fe42c2b5e6668a2a875678be44443942c868 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails Jun 9, 2024
@openjdk
Copy link

openjdk bot commented Jun 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 9, 2024
@mrserb mrserb marked this pull request as ready for review June 10, 2024 01:25
@mrserb
Copy link
Member Author

mrserb commented Jun 10, 2024

/clean the fix is identical to openjdk/jdk

@openjdk openjdk bot added rfr Pull request is ready for review clean labels Jun 10, 2024
@openjdk
Copy link

openjdk bot commented Jun 10, 2024

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 10, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2024

Webrevs

@openjdk openjdk bot added the approval label Jun 10, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Jul 11, 2024

keep open

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@mrserb
Copy link
Member Author

mrserb commented Aug 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

Going to push as commit aa44346.
Since your change was applied there have been 52 commits pushed to the master branch:

  • fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • 855480b: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
  • 4c9c5a4: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
  • 8b28c35: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2afd918: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910: 8321480: ISO 4217 Amendment 176 Update
  • ... and 42 more: https://git.openjdk.org/jdk8u-dev/compare/61dde50292198f9f35f906eef00b1fd002a19074...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2024
@openjdk openjdk bot closed this Aug 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@mrserb Pushed as commit aa44346.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant