Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284620: CodeBuffer may leak _overflow_arena #52

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 2, 2022

I would like to backport this patch to 8u for fixing a memory leak.

The original patch does not apply cleanly due to context difference. However, the patch is small, easily resolved manually.

Test:

  • hotspot_compiler

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk8u-dev pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.java.net/jdk8u-dev pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk8u-dev/pull/52.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4d45c3ebc493bb2c85dab84b97840c8ba093ab1f 8284620: CodeBuffer may leak _overflow_arena May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 12, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284620: CodeBuffer may leak _overflow_arena

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 51f69d9: 8221988: add possibility to build with Visual Studio 2019
  • 1b3e8ea: 8170530: bash configure output contains a typo in a suggested library name
  • 1067c54: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 1bc3be2: Merge
  • ee82a7d: 8282458: Update .jcheck/conf file for 8u move to git
  • d91ee59: Added tag jdk8u332-ga for changeset 37aca7715d13
  • 607b14e: 8285445: cannot open file "NUL:"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 12, 2022
@zhengyu123
Copy link
Contributor Author

Thanks for the review, @phohensee

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2022

Going to push as commit eb5711b.
Since your change was applied there have been 11 commits pushed to the master branch:

  • db52470: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • 3e0eb09: 8248876: LoadObject with bad base address created for exec file on linux
  • 6b94b65: 8278138: OpenJDK8 fails to start on Windows 8.1 after upgrading compiler to VS2017
  • 680b09c: 8168926: C2: Bytecode escape analyzer crashes due to stack overflow
  • 51f69d9: 8221988: add possibility to build with Visual Studio 2019
  • 1b3e8ea: 8170530: bash configure output contains a typo in a suggested library name
  • 1067c54: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 1bc3be2: Merge
  • ee82a7d: 8282458: Update .jcheck/conf file for 8u move to git
  • d91ee59: Added tag jdk8u332-ga for changeset 37aca7715d13
  • ... and 1 more: https://git.openjdk.java.net/jdk8u-dev/compare/62defc3dfc4b9ba5adfe3189f34fe8b3f59b94a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2022
@openjdk openjdk bot closed this May 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2022
@openjdk
Copy link

openjdk bot commented May 24, 2022

@zhengyu123 Pushed as commit eb5711b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

This has broken the build on AArch64: https://bugs.openjdk.java.net/browse/JDK-8287537

Not sure if it is related but this change uses delete _overflow_arena; while the original has delete cb->_overflow_arena;
I'm guessing the AArch64 build is trying to access something it does not expect to be NULL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants