8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5

[mrserb]

Hi all,

This pull request contains a backport of commit dedddd5a from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8266248 needs maintainer approval

Issue

• JDK-8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/520/head:pull/520
$ git checkout pull/520

Update a local copy of the PR:
$ git checkout pull/520
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 520

View PR using the GUI difftool:
$ git pr show -t 520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/520.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

/clean the patch is identical to openjdk/jdk

[openjdk]

@mrserb This backport pull request is now marked as clean

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ed8082d2)
• 00: Full (c6e902ad)

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[mrserb]

/integrate

[openjdk]

Going to push as commit fc33f51.
Since your change was applied there have been 3 commits pushed to the master branch:

• 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
• 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
• 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit fc33f51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.