-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330415: Update system property for Java SE specification maintenance version #521
Conversation
… version Reviewed-by: lancea, iris, prr, andrew
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Backporting the update of the "java.specification.maintenance.version" system property value from 5 to 6. (This has already been integrated in jdk8u-ri for JSR337). |
@justin-curtis-lu |
Hi @gnu-andrew, Thank you for approving the adding of the system property to 17u-dev. When you get the chance, can you also review the maintainer approval request for this PR, which proposes updating the value of the property from 5 to 6. |
/integrate |
@justin-curtis-lu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes as expected for JSR 337 MR 6 support.
/sponsor |
Going to push as commit f231e27.
Your commit was automatically rebased without conflicts. |
@LanceAndersen @justin-curtis-lu Pushed as commit f231e27. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which is a backport of openjdk/jdk8u-ri@bda97a2.
This is a trivial increment of the
"java.specification.maintenance.version"
system property value from 5 to 6.Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/521/head:pull/521
$ git checkout pull/521
Update a local copy of the PR:
$ git checkout pull/521
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/521/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 521
View PR using the GUI difftool:
$ git pr show -t 521
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/521.diff
Webrev
Link to Webrev Comment