Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330415: Update system property for Java SE specification maintenance version #521

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jun 17, 2024

Please review this PR which is a backport of openjdk/jdk8u-ri@bda97a2.
This is a trivial increment of the "java.specification.maintenance.version" system property value from 5 to 6.
Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330415 needs maintainer approval

Issue

  • JDK-8330415: Update system property for Java SE specification maintenance version (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/521/head:pull/521
$ git checkout pull/521

Update a local copy of the PR:
$ git checkout pull/521
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 521

View PR using the GUI difftool:
$ git pr show -t 521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/521.diff

Webrev

Link to Webrev Comment

… version

Reviewed-by: lancea, iris, prr, andrew
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8330415: Update system property for Java SE specification maintenance version

Reviewed-by: lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • fc15e99: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
  • ddce2b5: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • c8eb027: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
  • 16ea85b: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
  • 54f7734: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • 385e34d: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 44eac48: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
  • a0715ab: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • b499ea7: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
  • b1e2ea8: 8279164: Disable TLS_ECDH_* cipher suites
  • ... and 8 more: https://git.openjdk.org/jdk8u-dev/compare/663ecc703dd8526178e3aab0036ddeac8767ff0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport bda97a28e0d0830b3c07b33482c4d6a99524af99 8330415: Update system property for Java SE specification maintenance version Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

⚠️ @justin-curtis-lu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@justin-curtis-lu
Copy link
Member Author

/approval request Backporting the update of the "java.specification.maintenance.version" system property value from 5 to 6. (This has already been integrated in jdk8u-ri for JSR337).

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@justin-curtis-lu
8330415: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 3, 2024
@justin-curtis-lu
Copy link
Member Author

Hi @gnu-andrew,

Thank you for approving the adding of the system property to 17u-dev. When you get the chance, can you also review the maintainer approval request for this PR, which proposes updating the value of the property from 5 to 6.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 16, 2024
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 16, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@justin-curtis-lu
Your change (at version 0f53a72) is now ready to be sponsored by a Committer.

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as expected for JSR 337 MR 6 support.

@LanceAndersen
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

Going to push as commit f231e27.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 21e4278: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese
  • fc15e99: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
  • ddce2b5: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • c8eb027: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
  • 16ea85b: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
  • 54f7734: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • 385e34d: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 44eac48: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
  • a0715ab: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • b499ea7: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
  • ... and 9 more: https://git.openjdk.org/jdk8u-dev/compare/663ecc703dd8526178e3aab0036ddeac8767ff0f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 18, 2024
@openjdk openjdk bot closed this Jul 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 18, 2024
@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@LanceAndersen @justin-curtis-lu Pushed as commit f231e27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants