8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

[mrserb]

Hi all,

This pull request contains a backport of commit bc0379ea from the openjdk/jdk repository.

The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8275303 needs maintainer approval

Issue

• JDK-8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver (Bug - P4 - Approved)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/523/head:pull/523
$ git checkout pull/523

Update a local copy of the PR:
$ git checkout pull/523
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/523/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 523

View PR using the GUI difftool:
$ git pr show -t 523

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/523.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[mlbridge]

Webrevs

• 01: Full - Incremental (aef567bc)
• 00: Full (6397e2eb)

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[fthevenet]

Hi @mrserb.
I've been investigating an issue where an AWT app would cause an increase in CPU usage on Windows when the session is locked and the MS basic render driver is used (in this case because the app is used through a Remote Desktop session).
It turns out that JDK-8275303 is an effective workaround for such issues and I believe this should really be back-ported into JDK-8.
Would you mind re-opening this PR?
Thanks!

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[fthevenet]

Thanks @mrserb

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

/approval request
Backport for parity with 8u391. This change disables D3D functionality when the "Microsoft Basic Render Driver" is detected, as it may cause rendering issues.

[openjdk]

@mrserb
8275303: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8275303: The approval request has been approved.

[mrserb]

/integrate

[openjdk]

Going to push as commit a01bf31.

[openjdk]

@mrserb Pushed as commit a01bf31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.