Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327007: javax/swing/JSpinner/8008657/bug8008657.java fails #530

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 28, 2024

Hi all,

This pull request contains a backport of commit b7540df6 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 5 Mar 2024 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327007 needs maintainer approval

Issue

  • JDK-8327007: javax/swing/JSpinner/8008657/bug8008657.java fails (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/530/head:pull/530
$ git checkout pull/530

Update a local copy of the PR:
$ git checkout pull/530
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 530

View PR using the GUI difftool:
$ git pr show -t 530

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/530.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • d4adbe3: 8152207: Perform array bound checks while getting a length of bytecode instructions
  • 047b08a: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 24 more: https://git.openjdk.org/jdk8u-dev/compare/44eac48705dd89f20cda5c4384cbecf417555eb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b7540df6a4279c63e69d32b9d9834f7a427478d1 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 28, 2024
@mrserb mrserb marked this pull request as ready for review June 28, 2024 17:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 28, 2024
@mrserb
Copy link
Member Author

mrserb commented Jun 28, 2024

/clean The patch is identical to openjdk/jdk.

@openjdk openjdk bot added the clean label Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@mrserb This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@openjdk openjdk bot added the approval label Jun 28, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Aug 12, 2024

keep open

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@mrserb
Copy link
Member Author

mrserb commented Aug 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

Going to push as commit 4c9c5a4.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 8b28c35: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2afd918: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910: 8321480: ISO 4217 Amendment 176 Update
  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • ... and 27 more: https://git.openjdk.org/jdk8u-dev/compare/44eac48705dd89f20cda5c4384cbecf417555eb1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2024
@openjdk openjdk bot closed this Aug 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@mrserb Pushed as commit 4c9c5a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants