Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option #533

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jul 3, 2024

Hi all,

This pull request contains a backport of commit 0abb2b14 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8030795 needs maintainer approval

Issue

  • JDK-8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/533/head:pull/533
$ git checkout pull/533

Update a local copy of the PR:
$ git checkout pull/533
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 533

View PR using the GUI difftool:
$ git pr show -t 533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/533.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option

Reviewed-by: aph, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad: 8318951: Additional negative value check in JPEG decoding
  • aa44346: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/54f7734c7cea3a20d49103c4387ed9023992e5a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option Jul 3, 2024
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review July 3, 2024 04:57
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Jul 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 3, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Aug 12, 2024

keep open

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed clean.

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@gnu-andrew
8030795: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 28, 2024
@mrserb
Copy link
Member Author

mrserb commented Aug 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

Going to push as commit 7c13bd8.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 7d36fed: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 4942516: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad: 8318951: Additional negative value check in JPEG decoding
  • aa44346: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • fc33f51: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d01: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/54f7734c7cea3a20d49103c4387ed9023992e5a6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2024
@openjdk openjdk bot closed this Aug 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@mrserb Pushed as commit 7c13bd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants