8335978: [8u] incorrect include file name in semaphore.inline.hpp

[sendaoYan]

Hi all,
In file semaphore.inline.hpp, #include "runtime/interfaceSupport.inline.hpp" include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository.

Additional testing:

• linux x64 tier1/2/3
• linux aarch64 tier1/2/3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335978 needs maintainer approval

Issue

• JDK-8335978: [8u] incorrect include file name in semaphore.inline.hpp (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/543/head:pull/543
$ git checkout pull/543

Update a local copy of the PR:
$ git checkout pull/543
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 543

View PR using the GUI difftool:
$ git pr show -t 543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/543.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8335978: [8u] incorrect include file name in semaphore.inline.hpp

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• af84892: Merge
• 943a5ea: 8360147: Better Glyph drawing redux
• d24f35d: 8351422: Improve scripting supports
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/51b6307937d9584f8690e4916444e479eeafff28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (8ffbe6a4)
• 00: Full (61c05500)

[sendaoYan]

The GHA report several failures.

1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

2. Linux x86 gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java report timeout failure, I have create a issue JDK-8336400 to record this failure, I think it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

[sendaoYan]

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

[openjdk]

@sendaoYan
8335978: The approval request has been created successfully.

[phohensee]

interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

[sendaoYan]

interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

Thanks for the review.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/approval cancel

[openjdk]

@sendaoYan
8335978: The approval request has been cancelled successfully.

[sendaoYan]

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

[sendaoYan]

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sendaoYan
8335978: The approval request has been created successfully.

[openjdk]

@sendaoYan
8335978: The approval request was already up to date.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/approval request Fix incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

[openjdk]

@sendaoYan
8335978: The approval request has been updated successfully.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/open

[openjdk]

@sendaoYan This pull request is already open

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk]

@sendaoYan
8335978: The approval request has been updated successfully.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/touch

[openjdk]

@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

/approval request Fxi incorrect include file name in semaphore.inline.hpp, the change has been verfied, risk is low.

[openjdk]

@sendaoYan
8335978: The approval request has been updated successfully.

[jerboaa]

@sendaoYan Please merge latest master into this PR to get updated test runs.

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

GHA report 5 job fails, all the fails are known CA issues, they are unrelated to this PR.

Thanks for the review @phohensee

Thanks for the approved @jerboaa

/integrate

[openjdk]

@sendaoYan
Your change (at version 8ffbe6a) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 1694987.
Since your change was applied there have been 18 commits pushed to the master branch:

• af84892: Merge
• 943a5ea: 8360147: Better Glyph drawing redux
• d24f35d: 8351422: Improve scripting supports
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/51b6307937d9584f8690e4916444e479eeafff28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @sendaoYan Pushed as commit 1694987.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

/sponsor

Thanks @jerboaa.

[gnu-andrew]

Good catch. It looks like this was introduced by the JFR backport. It surprises me that there have been no warnings or errors produced for the missing include file or ThreadBlockInVM which it defines.

A gcc -E from the command line does show it:

$ gcc -I hotspot/src/share/vm -E hotspot/src/share/vm/runtime/semaphore.inline.hpp 
# 1 "hotspot/src/share/vm/runtime/semaphore.inline.hpp"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 1 "<command-line>" 2
# 1 "hotspot/src/share/vm/runtime/semaphore.inline.hpp"
hotspot/src/share/vm/runtime/semaphore.inline.hpp:28:10: fatal error: runtime/interfaceSupport.inline.hpp: No such file or directory
 #include "runtime/interfaceSupport.inline.hpp"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.