Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" #545

Closed
wants to merge 1 commit into from
Closed

8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" #545

wants to merge 1 commit into from

Conversation

adamfarley
Copy link
Contributor

@adamfarley adamfarley commented Jul 10, 2024 •
edited by openjdk bot
Loading

…lls: 51. After deopt 50"

Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1.

Backported manually from the jdk9u commit below:
1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8021775 needs maintainer approval

Issue

  • JDK-8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/545/head:pull/545
$ git checkout pull/545

Update a local copy of the PR:
$ git checkout pull/545
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 545

View PR using the GUI difftool:
$ git pr show -t 545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/545.diff

Webrev

Link to Webrev Comment

@adamfarley
8021775: compiler/8009761/Test8009761.java "Failed: init recursive ca…
84a48f2 
…lls: 51. After deopt 50"

Reimplemented the test using the Whitebox API to deterministically
trigger compilation and deoptimization. Now allowing number of
recursive calls to vary by 1.

Backported manually from the jdk9u commit below:
1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee

Signed-off-by: Adam Farley <adfarley@redhat.com>
@adamfarley adamfarley mentioned this pull request Jul 10, 2024
Closed
@adamfarley adamfarley changed the title 8021775: compiler/8009761/Test8009761.java "Failed: init recursive ca… Backport 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee Jul 10, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024 •
edited
Loading

@adamfarley This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8021775: compiler/8009761/Test8009761.java  "Failed: init recursive calls: 51. After deopt 50"

Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1.

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • 855480b: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
  • 4c9c5a4: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
  • 8b28c35: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2afd918: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910: 8321480: ISO 4217 Amendment 176 Update
  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/fc15e99a3218a88434c27da1d7d09a01c592d8f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

@openjdk openjdk bot added the approval label Aug 7, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 7, 2024

@adamfarley This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@adamfarley
Copy link
Contributor Author

/approval "Requesting a backport of this fix to prevent the issue documented in JDK-8330973. It's a clean merge."

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@adamfarley usage: /approval [<id>] (request|cancel) [<text>]

@adamfarley
Copy link
Contributor Author

/approval request "Requesting a backport of this fix to prevent the issue documented in JDK-8330973. It's a clean merge."

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@adamfarley
8021775: The approval request has been created successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@adamfarley
Copy link
Contributor Author

I will be going on vacation shortly. Please feel free to integrate this PR once sponsored. Thank you. :)

@jerboaa
Copy link
Contributor

jerboaa commented Aug 21, 2024

@adamfarley Please add /integrate and I'll sponsor.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 21, 2024

See #545 (comment) for the details.

@adamfarley
Copy link
Contributor Author

Afterwards, right. Got mixed up. Thanks for clarifying.

@adamfarley
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@adamfarley
Your change (at version 84a48f2) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 21, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

Going to push as commit 5c7f201.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • 855480b: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
  • 4c9c5a4: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
  • 8b28c35: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2afd918: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910: 8321480: ISO 4217 Amendment 176 Update
  • edbdf05: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • ... and 25 more: https://git.openjdk.org/jdk8u-dev/compare/fc15e99a3218a88434c27da1d7d09a01c592d8f9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2024
@openjdk openjdk bot closed this Aug 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@jerboaa @adamfarley Pushed as commit 5c7f201.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamfarley @jerboaa