Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307779: Relax the java.awt.Robot specification #549

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Jul 16, 2024

Hi all,

This pull request contains a backport of commit c0a876a5 from the openjdk/jdk8u-ri repository.

The commit being backported was authored by Alexander Zvegintsev on 16 May 2024 and was reviewed by Phil Race, Iris Clark, Lance Andersen and Andrew John Hughes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8331038 to be approved
  • JDK-8307779 needs maintainer approval

Issues

  • JDK-8307779: Relax the java.awt.Robot specification (Bug - P3 - Approved)
  • JDK-8331038: Relax the java.awt.Robot specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/549/head:pull/549
$ git checkout pull/549

Update a local copy of the PR:
$ git checkout pull/549
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 549

View PR using the GUI difftool:
$ git pr show -t 549

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/549.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@azvegint This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 765bd89: 8318039: GHA: Bump macOS and Xcode versions
  • f231e27: 8330415: Update system property for Java SE specification maintenance version
  • 21e4278: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac 8307779: Relax the java.awt.Robot specification Jul 16, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

⚠️ @azvegint This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 16, 2024
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

Going to push as commit c8d52b0.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 765bd89: 8318039: GHA: Bump macOS and Xcode versions
  • f231e27: 8330415: Update system property for Java SE specification maintenance version
  • 21e4278: 8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2024
@openjdk openjdk bot closed this Jul 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2024
@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@azvegint Pushed as commit c8d52b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants