Skip to content

8336928: GHA: Bundle artifacts removal broken #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Aug 14, 2024

Backport fixes code, which removes unnecessary artifacts (jdk builds), as it longer works after JDK-8324723.

Notes:

  • changeset is quite different form newer JDKs, because there are significant differences to GHA code
  • in jdk 8 bundle artifacts use transient prefix instead of bundle
  • Display current artifacts and Delete transient artifacts steps were updated to use documented REST API
  • I switched last step to use new actions/upload-artifact/merge@v4, which allows to turn last 3 steps into one

Testing:


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336928 needs maintainer approval

Issue

  • JDK-8336928: GHA: Bundle artifacts removal broken (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/560/head:pull/560
$ git checkout pull/560

Update a local copy of the PR:
$ git checkout pull/560
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 560

View PR using the GUI difftool:
$ git pr show -t 560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/560.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8336928: GHA: Bundle artifacts removal broken

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 98562166e4a4c8921709014423c6cbc993aa0d97 8336928: GHA: Bundle artifacts removal broken Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 14, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Backport fixes GHA code, which removes unnecessary artifacts (jdk builds), testing OK

@openjdk
Copy link

openjdk bot commented Aug 19, 2024

@zzambers
8336928: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 19, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Aug 19, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented Aug 19, 2024

@jerboaa
8336928: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 19, 2024
@zzambers
Copy link
Contributor Author

@jerboaa thanks
/integrate

@openjdk
Copy link

openjdk bot commented Aug 19, 2024

Going to push as commit edbdf05.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37: 8338144: [8u] Remove duplicate license files
  • fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e7: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 19, 2024
@openjdk openjdk bot closed this Aug 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 19, 2024
@openjdk
Copy link

openjdk bot commented Aug 19, 2024

@zzambers Pushed as commit edbdf05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants