Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9 #57

Closed
wants to merge 1 commit into from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented May 11, 2022

I would like to backport
JDK-8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9
The original patch applies cleanly after paths changes.

Testing:
build on Solaris11.4 sparcv9
tire1, jdk_awt and javax/swing/system/6799345/TestShutdown.java on Solaris11.4 sparcv9


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/57/head:pull/57
$ git checkout pull/57

Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk8u-dev pull/57/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 57

View PR using the GUI difftool:
$ git pr show -t 57

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/57.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2022

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4140fd05a447c888856c54aee22c475173030833 8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9 May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 11, 2022
@mlbridge
Copy link

mlbridge bot commented May 11, 2022

Webrevs

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport?

@ktakakuri
Copy link
Contributor Author

Could anyone review the PR please?

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport?

@ktakakuri
Copy link
Contributor Author

Could anyone review this PR please?

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 9, 2022

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

  • 972112e: 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit
  • e005185: 8235218: Minimal VM is broken after JDK-8173361
  • eeef4de: 8150669: C1 intrinsic for Class.isPrimitive
  • 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
  • a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation
  • 1b4f32d: 8173361: various crashes in JvmtiExport::post_compiled_method_load
  • cf6b628: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • 83e9095: 8280963: Incorrect PrintFlags formatting on Windows
  • 820ab13: 8235385: Crash on aarch64 JDK due to long offset
  • ... and 53 more: https://git.openjdk.org/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2022
@ktakakuri
Copy link
Contributor Author

@phohensee
Is it ok if I integrate?

@jerboaa
Copy link
Contributor

jerboaa commented Jun 10, 2022

@ktakakuri You need to apply for approval of the bug. Add a Fix Request comment explaining why the fix is needed and what the risks are. Also add a jdk8u-fix-request label so that maintainers will see the request. Once you have jdk8u-fix-yes on the bug you can integrate.

@ktakakuri
Copy link
Contributor Author

@ktakakuri You need to apply for approval of the bug. Add a Fix Request comment explaining why the fix is needed and what the risks are. Also add a jdk8u-fix-request label so that maintainers will see the request. Once you have jdk8u-fix-yes on the bug you can integrate.

Thank you for your comment.
I am concerned about the lack of reviewers.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 13, 2022

@ktakakuri Unfortunately, the OpenJDK wiki is offline at the moment due to an ongoing migration. Our wiki page explains this. In a nutshell, clean backports don't need a separate review. So in your case only maintainer approval is needed. That's what the label process described above is for. Only modified patches need a review. I take it you've run tests on relevant platforms and have seen no regressions?

@ktakakuri
Copy link
Contributor Author

@ktakakuri Unfortunately, the OpenJDK wiki is offline at the moment due to an ongoing migration. Our wiki page explains this. In a nutshell, clean backports don't need a separate review. So in your case only maintainer approval is needed. That's what the label process described above is for. Only modified patches need a review. I take it you've run tests on relevant platforms and have seen no regressions?

Thank you, that makes sense.
I added the Fix-request label.

@phohensee
Copy link
Member

If you add a /integrate comment, I can sponsor.

@ktakakuri
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 11, 2022
@openjdk
Copy link

openjdk bot commented Jul 11, 2022

@ktakakuri
Your change (at version 3f3956e) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 12, 2022

Going to push as commit 40a1859.
Since your change was applied there have been 66 commits pushed to the master branch:

  • de9f149: 8194873: right ALT key hotkeys no longer work in Swing components
  • 0de66bd: 8282538: PKCS11 tests fail on CentOS Stream 9
  • 4f7dd0c: 8256722: handle VC++:1927 VS2019 in abstract_vm_version
  • 972112e: 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit
  • e005185: 8235218: Minimal VM is broken after JDK-8173361
  • eeef4de: 8150669: C1 intrinsic for Class.isPrimitive
  • 6e8292f: 8283849: AsyncGetCallTrace may crash JVM on guarantee
  • ce73401: 8136354: [TEST_BUG] Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script
  • a3c0ed2: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation
  • 1b4f32d: 8173361: various crashes in JvmtiExport::post_compiled_method_load
  • ... and 56 more: https://git.openjdk.org/jdk8u-dev/compare/57d8d29080414dd038fffff1b97d97f3ab3f1570...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2022
@openjdk openjdk bot closed this Jul 12, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 12, 2022
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 12, 2022
@openjdk
Copy link

openjdk bot commented Jul 12, 2022

@phohensee @ktakakuri Pushed as commit 40a1859.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ktakakuri ktakakuri deleted the 8130895 branch August 22, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants