-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9 #57
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Could someone please review this backport? |
Could anyone review the PR please? |
Could someone please review this backport? |
Could anyone review this PR please? |
/clean |
@phohensee This backport pull request is now marked as clean |
@ktakakuri This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 63 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@phohensee |
@ktakakuri You need to apply for approval of the bug. Add a |
Thank you for your comment. |
@ktakakuri Unfortunately, the OpenJDK wiki is offline at the moment due to an ongoing migration. Our wiki page explains this. In a nutshell, clean backports don't need a separate review. So in your case only maintainer approval is needed. That's what the label process described above is for. Only modified patches need a review. I take it you've run tests on relevant platforms and have seen no regressions? |
Thank you, that makes sense. |
If you add a /integrate comment, I can sponsor. |
/integrate |
@ktakakuri |
/sponsor |
Going to push as commit 40a1859.
Your commit was automatically rebased without conflicts. |
@phohensee @ktakakuri Pushed as commit 40a1859. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport
JDK-8130895: Test javax/swing/system/6799345/TestShutdown.java fails on Solaris11 Sparcv9
The original patch applies cleanly after paths changes.
Testing:
build on Solaris11.4 sparcv9
tire1, jdk_awt and javax/swing/system/6799345/TestShutdown.java on Solaris11.4 sparcv9
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev pull/57/head:pull/57
$ git checkout pull/57
Update a local copy of the PR:
$ git checkout pull/57
$ git pull https://git.openjdk.org/jdk8u-dev pull/57/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 57
View PR using the GUI difftool:
$ git pr show -t 57
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/57.diff