Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Aug 28, 2024

Hi all,

This pull request contains a backport of commit eb790603 from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy.

Thanks!


Progress

  • JDK-8133287 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/570/head:pull/570
$ git checkout pull/570

Update a local copy of the PR:
$ git checkout pull/570
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 570

View PR using the GUI difftool:
$ git pr show -t 570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/570.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode

Add @build tag containing ParallelProbes and SimpleFileTypeDetector and reinstate othervm mode.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport eb790603374262134543bb03171a6ead1b13fc4b 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 28, 2024
@mrserb mrserb marked this pull request as ready for review August 29, 2024 02:14
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2024

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 29, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2024

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 24, 2024
@mrserb
Copy link
Member Author

mrserb commented Oct 24, 2024

/open

@openjdk openjdk bot reopened this Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@mrserb This pull request is now open

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 25, 2024
@mrserb
Copy link
Member Author

mrserb commented Oct 29, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

Going to push as commit 41f479c.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2024
@openjdk openjdk bot closed this Oct 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2024
@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@mrserb Pushed as commit 41f479c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant