Skip to content

8339394: Bump update version of OpenJDK: 8u442#572

Closed
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
gnu-andrew:8u442
Closed

8339394: Bump update version of OpenJDK: 8u442#572
gnu-andrew wants to merge 1 commit intoopenjdk:masterfrom
gnu-andrew:8u442

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Sep 2, 2024

Rampdown for 8u432 has begun. 8u-dev needs to transition to 8u442.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339394 needs maintainer approval

Issue

  • JDK-8339394: Bump update version of OpenJDK: 8u442 (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/572/head:pull/572
$ git checkout pull/572

Update a local copy of the PR:
$ git checkout pull/572
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 572

View PR using the GUI difftool:
$ git pr show -t 572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/572.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2024

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8339394: Bump update version of OpenJDK: 8u442

Reviewed-by: sgehwolf, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2024

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

The version openjdk8u442 seems to be available in the bug system now.
/approval request Necessary process bump to start new release cycle.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@gnu-andrew
8339394: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 4, 2024
@gnu-andrew
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

Going to push as commit 503ae0b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2024
@openjdk openjdk bot closed this Sep 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@gnu-andrew Pushed as commit 503ae0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants